2024-02-09 15:14:37

by Abel Vesa

[permalink] [raw]
Subject: [PATCH 1/2] dt-bindings: phy: qcom,snps-eusb2-repeater: Add compatible for SMB2360

Add a dt-bindings compatible string for the Qualcomm's SMB2360 PMIC.

Signed-off-by: Abel Vesa <[email protected]>
---
Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
index 24c733c10e0e..6be20c157568 100644
--- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
@@ -21,6 +21,7 @@ properties:
- qcom,pm7550ba-eusb2-repeater
- const: qcom,pm8550b-eusb2-repeater
- const: qcom,pm8550b-eusb2-repeater
+ - const: qcom,smb2360-eusb2-repeater

reg:
maxItems: 1

--
2.34.1



2024-02-11 16:27:47

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: phy: qcom,snps-eusb2-repeater: Add compatible for SMB2360

On 09/02/2024 16:14, Abel Vesa wrote:
> Add a dt-bindings compatible string for the Qualcomm's SMB2360 PMIC.
>
> Signed-off-by: Abel Vesa <[email protected]>
> ---
> Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> index 24c733c10e0e..6be20c157568 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> @@ -21,6 +21,7 @@ properties:
> - qcom,pm7550ba-eusb2-repeater
> - const: qcom,pm8550b-eusb2-repeater
> - const: qcom,pm8550b-eusb2-repeater
> + - const: qcom,smb2360-eusb2-repeater

Make it an enum with previous entry. Same effect, but it is easier to
read, especially in limited diffs, and more obvious.

Anyway:

Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof