2024-02-09 15:14:54

by Abel Vesa

Subject: [PATCH 2/2] phy: qualcomm: phy-qcom-eusb2-repeater: Add support for SMB2360

The SMB2360 PMICs contain the same eUSB2 repeater as the PM8550B,
so add dedicated compatible for SMB82360.

Signed-off-by: Abel Vesa <[email protected]>
---
drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)

diff --git a/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c b/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
index a43e20abb10d..68cc8e24f383 100644
--- a/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
+++ b/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
@@ -88,6 +88,12 @@ static const u32 pm8550b_init_tbl[NUM_TUNE_FIELDS] = {
[TUNE_USB2_PREEM] = 0x5,
};

+static const u32 smb2360_init_tbl[NUM_TUNE_FIELDS] = {
+ [TUNE_IUSB2] = 0x5,
+ [TUNE_SQUELCH_U] = 0x3,
+ [TUNE_USB2_PREEM] = 0x2,
+};
+
static const struct eusb2_repeater_cfg pm8550b_eusb2_cfg = {
.init_tbl = pm8550b_init_tbl,
.init_tbl_num = ARRAY_SIZE(pm8550b_init_tbl),
@@ -95,6 +101,13 @@ static const struct eusb2_repeater_cfg pm8550b_eusb2_cfg = {
.num_vregs = ARRAY_SIZE(pm8550b_vreg_l),
};

+static const struct eusb2_repeater_cfg smb2360_eusb2_cfg = {
+ .init_tbl = smb2360_init_tbl,
+ .init_tbl_num = ARRAY_SIZE(smb2360_init_tbl),
+ .vreg_list = pm8550b_vreg_l,
+ .num_vregs = ARRAY_SIZE(pm8550b_vreg_l),
+};
+
static int eusb2_repeater_init_vregs(struct eusb2_repeater *rptr)
{
int num = rptr->cfg->num_vregs;
@@ -271,6 +284,10 @@ static const struct of_device_id eusb2_repeater_of_match_table[] = {
.compatible = "qcom,pm8550b-eusb2-repeater",
.data = &pm8550b_eusb2_cfg,
},
+ {
+ .compatible = "qcom,smb2360-eusb2-repeater",
+ .data = &smb2360_eusb2_cfg,
+ },
{ },
};
MODULE_DEVICE_TABLE(of, eusb2_repeater_of_match_table);

--
2.34.1

2024-02-09 15:42:38

by Dmitry Baryshkov

Subject: Re: [PATCH 2/2] phy: qualcomm: phy-qcom-eusb2-repeater: Add support for SMB2360

On Fri, 9 Feb 2024 at 17:14, Abel Vesa <[email protected]> wrote:
>
> The SMB2360 PMICs contain the same eUSB2 repeater as the PM8550B,
> so add dedicated compatible for SMB82360.

"...same repeater as the PM8550B, but requiring different settings..."

With that fixed:
Reviewed-by: Dmitry Baryshkov <[email protected]>

>
> Signed-off-by: Abel Vesa <[email protected]>
> ---
> drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c b/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
> index a43e20abb10d..68cc8e24f383 100644
> --- a/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
> +++ b/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
> @@ -88,6 +88,12 @@ static const u32 pm8550b_init_tbl[NUM_TUNE_FIELDS] = {
> [TUNE_USB2_PREEM] = 0x5,
> };
>
> +static const u32 smb2360_init_tbl[NUM_TUNE_FIELDS] = {
> + [TUNE_IUSB2] = 0x5,
> + [TUNE_SQUELCH_U] = 0x3,
> + [TUNE_USB2_PREEM] = 0x2,
> +};
> +
> static const struct eusb2_repeater_cfg pm8550b_eusb2_cfg = {
> .init_tbl = pm8550b_init_tbl,
> .init_tbl_num = ARRAY_SIZE(pm8550b_init_tbl),
> @@ -95,6 +101,13 @@ static const struct eusb2_repeater_cfg pm8550b_eusb2_cfg = {
> .num_vregs = ARRAY_SIZE(pm8550b_vreg_l),
> };
>
> +static const struct eusb2_repeater_cfg smb2360_eusb2_cfg = {
> + .init_tbl = smb2360_init_tbl,
> + .init_tbl_num = ARRAY_SIZE(smb2360_init_tbl),
> + .vreg_list = pm8550b_vreg_l,
> + .num_vregs = ARRAY_SIZE(pm8550b_vreg_l),
> +};
> +
> static int eusb2_repeater_init_vregs(struct eusb2_repeater *rptr)
> {
> int num = rptr->cfg->num_vregs;
> @@ -271,6 +284,10 @@ static const struct of_device_id eusb2_repeater_of_match_table[] = {
> .compatible = "qcom,pm8550b-eusb2-repeater",
> .data = &pm8550b_eusb2_cfg,
> },
> + {
> + .compatible = "qcom,smb2360-eusb2-repeater",
> + .data = &smb2360_eusb2_cfg,
> + },
> { },
> };
> MODULE_DEVICE_TABLE(of, eusb2_repeater_of_match_table);
>
> --
> 2.34.1
>
>


--
With best wishes
Dmitry