2024-02-09 12:38:47

by POPESCU Catalin

Subject: [PATCH v3 1/2] dt-bindings: net: dp83826: support TX data voltage tuning

Add properties ti,cfg-dac-minus-one-bp/ti,cfg-dac-plus-one-bp
to support voltage tuning of logical levels -1/+1 of the MLT-3
encoded TX data.

Signed-off-by: Catalin Popescu <[email protected]>
---
Changes in v2:
- squash the 2 DT bindings patches in one single patch
- drop redundant "binding" from the DT bindings patch title
- rename DT properties and define them as percentage
- add default value for each new DT property

Changes in v3:
- rename properties to "-bp" and change their admissible values
accordingly
---
.../devicetree/bindings/net/ti,dp83822.yaml | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/ti,dp83822.yaml b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
index db74474207ed..8f4350be689c 100644
--- a/Documentation/devicetree/bindings/net/ti,dp83822.yaml
+++ b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
@@ -62,6 +62,24 @@ properties:
for the PHY. The internal delay for the PHY is fixed to 3.5ns relative
to transmit data.

+ ti,cfg-dac-minus-one-bp:
+ description: |
+ DP83826 PHY only.
+ Sets the voltage ratio (with respect to the nominal value)
+ of the logical level -1 for the MLT-3 encoded TX data.
+ enum: [5000, 5625, 6250, 6875, 7500, 8125, 8750, 9375, 10000,
+ 10625, 11250, 11875, 12500, 13125, 13750, 14375, 15000]
+ default: 10000
+
+ ti,cfg-dac-plus-one-bp:
+ description: |
+ DP83826 PHY only.
+ Sets the voltage ratio (with respect to the nominal value)
+ of the logical level +1 for the MLT-3 encoded TX data.
+ enum: [5000, 5625, 6250, 6875, 7500, 8125, 8750, 9375, 10000,
+ 10625, 11250, 11875, 12500, 13125, 13750, 14375, 15000]
+ default: 10000
+
required:
- reg


base-commit: 1f719a2f3fa67665578c759ac34fd3d3690c1a20
prerequisite-patch-id: 0000000000000000000000000000000000000000
--
2.34.1

2024-02-11 16:31:22

by Krzysztof Kozlowski

Subject: Re: [PATCH v3 1/2] dt-bindings: net: dp83826: support TX data voltage tuning

On 09/02/2024 13:36, Catalin Popescu wrote:
> Add properties ti,cfg-dac-minus-one-bp/ti,cfg-dac-plus-one-bp
> to support voltage tuning of logical levels -1/+1 of the MLT-3
> encoded TX data.
>
> Signed-off-by: Catalin Popescu <[email protected]>
> ---
> Changes in v2:

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof