2024-02-12 09:34:41

by Kent Gibson

[permalink] [raw]
Subject: [PATCH] Documentation: gpio: clarify sysfs line values are logical

Clarify that line values are logical, not physical, by replacing high/low
terminology with active/inactive.

Signed-off-by: Kent Gibson <[email protected]>
---
Documentation/userspace-api/gpio/sysfs.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/userspace-api/gpio/sysfs.rst b/Documentation/userspace-api/gpio/sysfs.rst
index e12037a0f2b4..116921048b18 100644
--- a/Documentation/userspace-api/gpio/sysfs.rst
+++ b/Documentation/userspace-api/gpio/sysfs.rst
@@ -87,9 +87,9 @@ and have the following read/write attributes:
allow userspace to reconfigure this GPIO's direction.

"value" ...
- reads as either 0 (low) or 1 (high). If the GPIO
+ reads as either 0 (inactive) or 1 (active). If the GPIO
is configured as an output, this value may be written;
- any nonzero value is treated as high.
+ any nonzero value is treated as active.

If the pin can be configured as interrupt-generating interrupt
and if it has been configured to generate interrupts (see the
--
2.39.2



2024-02-12 09:55:52

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH] Documentation: gpio: clarify sysfs line values are logical

On Mon, Feb 12, 2024 at 11:34 AM Kent Gibson <[email protected]> wrote:
>
> Clarify that line values are logical, not physical, by replacing high/low
> terminology with active/inactive.

For this
Reviewed-by: Andy Shevchenko <[email protected]>

But as I said there are much more...

--
With Best Regards,
Andy Shevchenko

2024-02-14 09:31:33

by Bartosz Golaszewski

[permalink] [raw]
Subject: Re: [PATCH] Documentation: gpio: clarify sysfs line values are logical

On Mon, Feb 12, 2024 at 10:34 AM Kent Gibson <[email protected]> wrote:
>
> Clarify that line values are logical, not physical, by replacing high/low
> terminology with active/inactive.
>
> Signed-off-by: Kent Gibson <[email protected]>
> ---
> Documentation/userspace-api/gpio/sysfs.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/userspace-api/gpio/sysfs.rst b/Documentation/userspace-api/gpio/sysfs.rst
> index e12037a0f2b4..116921048b18 100644
> --- a/Documentation/userspace-api/gpio/sysfs.rst
> +++ b/Documentation/userspace-api/gpio/sysfs.rst
> @@ -87,9 +87,9 @@ and have the following read/write attributes:
> allow userspace to reconfigure this GPIO's direction.
>
> "value" ...
> - reads as either 0 (low) or 1 (high). If the GPIO
> + reads as either 0 (inactive) or 1 (active). If the GPIO
> is configured as an output, this value may be written;
> - any nonzero value is treated as high.
> + any nonzero value is treated as active.
>
> If the pin can be configured as interrupt-generating interrupt
> and if it has been configured to generate interrupts (see the
> --
> 2.39.2
>

Applied, thanks!

Bart