2024-02-13 15:24:59

by Naresh Solanki

[permalink] [raw]
Subject: [PATCH] regulator (max5970): Fix regulator child node name

Update regulator child node name to lower case i.e., sw0 & sw1 as
descibed in max5970 dt binding.

Signed-off-by: Naresh Solanki <[email protected]>
---
drivers/regulator/max5970-regulator.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/regulator/max5970-regulator.c b/drivers/regulator/max5970-regulator.c
index 830a1c4cd705..8bbcd983a74a 100644
--- a/drivers/regulator/max5970-regulator.c
+++ b/drivers/regulator/max5970-regulator.c
@@ -29,8 +29,8 @@ struct max5970_regulator {
};

enum max597x_regulator_id {
- MAX597X_SW0,
- MAX597X_SW1,
+ MAX597X_sw0,
+ MAX597X_sw1,
};

static int max5970_read_adc(struct regmap *regmap, int reg, long *val)
@@ -378,8 +378,8 @@ static int max597x_dt_parse(struct device_node *np,
}

static const struct regulator_desc regulators[] = {
- MAX597X_SWITCH(SW0, MAX5970_REG_CHXEN, 0, "vss1"),
- MAX597X_SWITCH(SW1, MAX5970_REG_CHXEN, 1, "vss2"),
+ MAX597X_SWITCH(sw0, MAX5970_REG_CHXEN, 0, "vss1"),
+ MAX597X_SWITCH(sw1, MAX5970_REG_CHXEN, 1, "vss2"),
};

static int max597x_regmap_read_clear(struct regmap *map, unsigned int reg,

base-commit: 3240695334aa17325671e9ef37bba43038fc4181
--
2.42.0



2024-02-13 15:48:22

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator (max5970): Fix regulator child node name

On Tue, Feb 13, 2024 at 08:28:00PM +0530, Naresh Solanki wrote:
> Update regulator child node name to lower case i.e., sw0 & sw1 as
> descibed in max5970 dt binding.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.


Attachments:
(No filename) (506.00 B)
signature.asc (499.00 B)
Download all attachments

2024-02-13 17:38:30

by Naresh Solanki

[permalink] [raw]
Subject: Re: [PATCH] regulator (max5970): Fix regulator child node name

Hi,


On Tue, 13 Feb 2024 at 21:07, Mark Brown <[email protected]> wrote:
>
> On Tue, Feb 13, 2024 at 08:28:00PM +0530, Naresh Solanki wrote:
> > Update regulator child node name to lower case i.e., sw0 & sw1 as
> > descibed in max5970 dt binding.
>
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
Ack.

Regards,
Naresh

2024-02-13 22:36:42

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator (max5970): Fix regulator child node name

On Tue, 13 Feb 2024 20:28:00 +0530, Naresh Solanki wrote:
> Update regulator child node name to lower case i.e., sw0 & sw1 as
> descibed in max5970 dt binding.
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator (max5970): Fix regulator child node name
commit: e5d40e9afd84cec01cdbbbfe62d52f89959ab3ee

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark