2024-02-14 14:05:18

by Rafał Miłecki

[permalink] [raw]
Subject: [PATCH V2 1/2] dt-bindings: pwm: mediatek,mt2712: add compatible for MT7988

From: Rafał Miłecki <[email protected]>

MT7988 has on-SoC controller that can control up to 8 PWM interfaces. It
differs from blocks on other SoCs (amount of PWMs & registers) so it
needs its own compatible string.

Signed-off-by: Rafał Miłecki <[email protected]>
---
V2: Explain new compatibility string reason in commit body

Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml b/Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml
index 0fbe8a6469eb..a5c308801619 100644
--- a/Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml
@@ -24,6 +24,7 @@ properties:
- mediatek,mt7629-pwm
- mediatek,mt7981-pwm
- mediatek,mt7986-pwm
+ - mediatek,mt7988-pwm
- mediatek,mt8183-pwm
- mediatek,mt8365-pwm
- mediatek,mt8516-pwm
--
2.35.3



2024-02-14 14:05:28

by Rafał Miłecki

[permalink] [raw]
Subject: [PATCH V2 2/2] pwm: mediatek: add support for MT7988

From: Rafał Miłecki <[email protected]>

MT7988 uses new registers layout just like MT7981 but it supports 8 PWM
interfaces.

Signed-off-by: Rafał Miłecki <[email protected]>
---
V2: New patch in the series

drivers/pwm/pwm-mediatek.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
index 562102a47ac0..292c8bd5b343 100644
--- a/drivers/pwm/pwm-mediatek.c
+++ b/drivers/pwm/pwm-mediatek.c
@@ -339,6 +339,13 @@ static const struct pwm_mediatek_of_data mt7986_pwm_data = {
.reg_offset = mtk_pwm_reg_offset_v1,
};

+static const struct pwm_mediatek_of_data mt7988_pwm_data = {
+ .num_pwms = 8,
+ .pwm45_fixup = false,
+ .has_ck_26m_sel = false,
+ .reg_offset = mtk_pwm_reg_offset_v2,
+};
+
static const struct pwm_mediatek_of_data mt8183_pwm_data = {
.num_pwms = 4,
.pwm45_fixup = false,
@@ -369,6 +376,7 @@ static const struct of_device_id pwm_mediatek_of_match[] = {
{ .compatible = "mediatek,mt7629-pwm", .data = &mt7629_pwm_data },
{ .compatible = "mediatek,mt7981-pwm", .data = &mt7981_pwm_data },
{ .compatible = "mediatek,mt7986-pwm", .data = &mt7986_pwm_data },
+ { .compatible = "mediatek,mt7988-pwm", .data = &mt7988_pwm_data },
{ .compatible = "mediatek,mt8183-pwm", .data = &mt8183_pwm_data },
{ .compatible = "mediatek,mt8365-pwm", .data = &mt8365_pwm_data },
{ .compatible = "mediatek,mt8516-pwm", .data = &mt8516_pwm_data },
--
2.35.3


2024-02-14 14:19:11

by Daniel Golle

[permalink] [raw]
Subject: Re: [PATCH V2 2/2] pwm: mediatek: add support for MT7988

On Wed, Feb 14, 2024 at 03:04:54PM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <[email protected]>
>
> MT7988 uses new registers layout just like MT7981 but it supports 8 PWM
> interfaces.
>
> Signed-off-by: Rafał Miłecki <[email protected]>

Reviewed-by: Daniel Golle <[email protected]>

> ---
> V2: New patch in the series
>
> drivers/pwm/pwm-mediatek.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
> index 562102a47ac0..292c8bd5b343 100644
> --- a/drivers/pwm/pwm-mediatek.c
> +++ b/drivers/pwm/pwm-mediatek.c
> @@ -339,6 +339,13 @@ static const struct pwm_mediatek_of_data mt7986_pwm_data = {
> .reg_offset = mtk_pwm_reg_offset_v1,
> };
>
> +static const struct pwm_mediatek_of_data mt7988_pwm_data = {
> + .num_pwms = 8,
> + .pwm45_fixup = false,
> + .has_ck_26m_sel = false,
> + .reg_offset = mtk_pwm_reg_offset_v2,
> +};
> +
> static const struct pwm_mediatek_of_data mt8183_pwm_data = {
> .num_pwms = 4,
> .pwm45_fixup = false,
> @@ -369,6 +376,7 @@ static const struct of_device_id pwm_mediatek_of_match[] = {
> { .compatible = "mediatek,mt7629-pwm", .data = &mt7629_pwm_data },
> { .compatible = "mediatek,mt7981-pwm", .data = &mt7981_pwm_data },
> { .compatible = "mediatek,mt7986-pwm", .data = &mt7986_pwm_data },
> + { .compatible = "mediatek,mt7988-pwm", .data = &mt7988_pwm_data },
> { .compatible = "mediatek,mt8183-pwm", .data = &mt8183_pwm_data },
> { .compatible = "mediatek,mt8365-pwm", .data = &mt8365_pwm_data },
> { .compatible = "mediatek,mt8516-pwm", .data = &mt8516_pwm_data },
> --
> 2.35.3
>
>

2024-02-14 15:44:46

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH V2 1/2] dt-bindings: pwm: mediatek,mt2712: add compatible for MT7988

On 14/02/2024 15:04, Rafał Miłecki wrote:
> From: Rafał Miłecki <[email protected]>
>
> MT7988 has on-SoC controller that can control up to 8 PWM interfaces. It
> differs from blocks on other SoCs (amount of PWMs & registers) so it
> needs its own compatible string.
>
> Signed-off-by: Rafał Miłecki <[email protected]>
> ---

Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


Subject: Re: [PATCH V2 2/2] pwm: mediatek: add support for MT7988

Il 14/02/24 15:04, Rafał Miłecki ha scritto:
> From: Rafał Miłecki <[email protected]>
>
> MT7988 uses new registers layout just like MT7981 but it supports 8 PWM
> interfaces.
>
> Signed-off-by: Rafał Miłecki <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>


Subject: Re: [PATCH V2 1/2] dt-bindings: pwm: mediatek,mt2712: add compatible for MT7988

Il 14/02/24 15:04, Rafał Miłecki ha scritto:
> From: Rafał Miłecki <[email protected]>
>
> MT7988 has on-SoC controller that can control up to 8 PWM interfaces. It
> differs from blocks on other SoCs (amount of PWMs & registers) so it
> needs its own compatible string.
>
> Signed-off-by: Rafał Miłecki <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>


2024-02-15 12:32:40

by Uwe Kleine-König

[permalink] [raw]
Subject: Re: [PATCH V2 1/2] dt-bindings: pwm: mediatek,mt2712: add compatible for MT7988

Hello,

On Wed, Feb 14, 2024 at 03:04:53PM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <[email protected]>
>
> MT7988 has on-SoC controller that can control up to 8 PWM interfaces. It
> differs from blocks on other SoCs (amount of PWMs & registers) so it
> needs its own compatible string.
>
> Signed-off-by: Rafał Miłecki <[email protected]>
> ---
> V2: Explain new compatibility string reason in commit body
>
> Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml | 1 +
> 1 file changed, 1 insertion(+)

Applied both patches to
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next

Best regards and thanks
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |


Attachments:
(No filename) (846.00 B)
signature.asc (499.00 B)
Download all attachments