2024-02-15 06:55:16

by Anshuman Khandual

[permalink] [raw]
Subject: [PATCH] arm64/sysreg: Add register fields for ID_AA64DFR1_EL1

This adds register fields for ID_AA64DFR1_EL1 as per the definitions based
on DDI0601 2023-12.

Cc: Catalin Marinas <[email protected]>
Cc: Will Deacon <[email protected]>
Cc: Mark Brown <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Anshuman Khandual <[email protected]>
---
arch/arm64/tools/sysreg | 28 +++++++++++++++++++++++++++-
1 file changed, 27 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
index 94692abfeeb9..1cd06edfad3b 100644
--- a/arch/arm64/tools/sysreg
+++ b/arch/arm64/tools/sysreg
@@ -1253,7 +1253,33 @@ EndEnum
EndSysreg

Sysreg ID_AA64DFR1_EL1 3 0 0 5 1
-Res0 63:0
+Field 63:56 ABL_CMPs
+Field 55:52 DPFZS
+UnsignedEnum 51:48 EBEP
+ 0b0000 NI
+ 0b0001 IMP
+EndEnum
+UnsignedEnum 47:44 ITE
+ 0b0000 NI
+ 0b0001 IMP
+EndEnum
+UnsignedEnum 43:40 ABLE
+ 0b0000 NI
+ 0b0001 IMP
+EndEnum
+UnsignedEnum 39:36 PMICNTR
+ 0b0000 NI
+ 0b0001 IMP
+EndEnum
+UnsignedEnum 35:32 SPMU
+ 0b0000 NI
+ 0b0001 IMP
+ 0b0010 IMP_SPMZR
+EndEnum
+Field 31:24 CTX_CMPs
+Field 23:16 WRPs
+Field 15:8 BRPs
+Field 7:0 SYSPMUID
EndSysreg

Sysreg ID_AA64AFR0_EL1 3 0 0 5 4
--
2.25.1



2024-02-15 13:05:03

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] arm64/sysreg: Add register fields for ID_AA64DFR1_EL1

On Thu, Feb 15, 2024 at 12:24:54PM +0530, Anshuman Khandual wrote:

> Sysreg ID_AA64DFR1_EL1 3 0 0 5 1
> -Res0 63:0
> +Field 63:56 ABL_CMPs
> +Field 55:52 DPFZS

This is documented in the architecture as an enumeration, though I'm not
immediately seeing what values to use.

Otherwise this looks good.


Attachments:
(No filename) (314.00 B)
signature.asc (499.00 B)
Download all attachments

2024-02-18 00:34:51

by Anshuman Khandual

[permalink] [raw]
Subject: Re: [PATCH] arm64/sysreg: Add register fields for ID_AA64DFR1_EL1



On 2/15/24 18:34, Mark Brown wrote:
> On Thu, Feb 15, 2024 at 12:24:54PM +0530, Anshuman Khandual wrote:
>
>> Sysreg ID_AA64DFR1_EL1 3 0 0 5 1
>> -Res0 63:0
>> +Field 63:56 ABL_CMPs
>> +Field 55:52 DPFZS
>
> This is documented in the architecture as an enumeration, though I'm not
> immediately seeing what values to use.

Just wondering - would something like the following make sense. Because
0b0000 signifies that the cycle counter would just ignore PMCR_EL0.FZS,
where as it gets frozen with 0b0001.

UnsignedEnum 55:52 DPFZS
0b0000 IGNR
0b0001 FRZN
EndEnum

>
> Otherwise this looks good.

2024-02-19 13:42:48

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] arm64/sysreg: Add register fields for ID_AA64DFR1_EL1

On Sun, Feb 18, 2024 at 06:04:34AM +0530, Anshuman Khandual wrote:

> Just wondering - would something like the following make sense. Because
> 0b0000 signifies that the cycle counter would just ignore PMCR_EL0.FZS,
> where as it gets frozen with 0b0001.

> UnsignedEnum 55:52 DPFZS
> 0b0000 IGNR
> 0b0001 FRZN
> EndEnum

LGTM.


Attachments:
(No filename) (360.00 B)
signature.asc (499.00 B)
Download all attachments