2024-02-15 19:43:54

by Aaron Parfitt

Subject: [PATCH v2] Staging: rtl8192e: rtl819x_HTProc: Removed braces from single statement block in ht_on_assoc_rsp

Remove braces from single statement blocks in the rtl8192e staging
driver to clear checkpatch.pl warnings, improving code readability
and adhering to coding style guidelines.

Changelog since v1:
- Updated the subject line to make it more unique and descriptive.
- Refined the patch description for clarity and conciseness.
- Incorporated feedback from Philipp to improve code style compliance.

Signed-off-by: Aaron Parfitt <[email protected]>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 6d0912f90198..49b882c363bf 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -480,9 +480,9 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee)
}

ht_info->current_mpdu_density = pPeerHTCap->MPDUDensity;
- if (ht_info->iot_action & HT_IOT_ACT_TX_USE_AMSDU_8K) {
+ if (ht_info->iot_action & HT_IOT_ACT_TX_USE_AMSDU_8K)
ht_info->current_ampdu_enable = false;
- }
+
ht_info->cur_rx_reorder_enable = 1;

if (pPeerHTCap->MCS[0] == 0)
--
2.43.0

2024-02-15 19:53:30

by Philipp Hortmann

Subject: Re: [PATCH v2] Staging: rtl8192e: rtl819x_HTProc: Removed braces from single statement block in ht_on_assoc_rsp

Hi Aaron,

the changelog needs to be below the three minus "---".

Look for examples: https://lore.kernel.org/linux-staging/

Please omit the changelog line with my name... that is not relevant...

Is the length of the subject line within the expected range?

Thanks for your support.

Bye Philipp


On 15.02.24 20:40, Aaron Parfitt wrote:
> Remove braces from single statement blocks in the rtl8192e staging
> driver to clear checkpatch.pl warnings, improving code readability
> and adhering to coding style guidelines.
>
> Changelog since v1:
> - Updated the subject line to make it more unique and descriptive.
> - Refined the patch description for clarity and conciseness.
> - Incorporated feedback from Philipp to improve code style compliance.
>
> Signed-off-by: Aaron Parfitt <[email protected]>
> ---
> drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> index 6d0912f90198..49b882c363bf 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> @@ -480,9 +480,9 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee)
> }
>
> ht_info->current_mpdu_density = pPeerHTCap->MPDUDensity;
> - if (ht_info->iot_action & HT_IOT_ACT_TX_USE_AMSDU_8K) {
> + if (ht_info->iot_action & HT_IOT_ACT_TX_USE_AMSDU_8K)
> ht_info->current_ampdu_enable = false;
> - }
> +
> ht_info->cur_rx_reorder_enable = 1;
>
> if (pPeerHTCap->MCS[0] == 0)