2024-02-17 20:13:37

by Ricardo B. Marliere

Subject: [PATCH 01/12] net: usbnet: constify the struct device_type usage

Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
core can properly handle constant struct device_type. Move the wlan_type
and wwan_type variables to be constant structures as well, placing it into
read-only memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Ricardo B. Marliere <[email protected]>
---
drivers/net/usb/usbnet.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 2d14b0d78541..b21ebe24057f 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1654,11 +1654,11 @@ static const struct net_device_ops usbnet_netdev_ops = {

// precondition: never called in_interrupt

-static struct device_type wlan_type = {
+static const struct device_type wlan_type = {
.name = "wlan",
};

-static struct device_type wwan_type = {
+static const struct device_type wwan_type = {
.name = "wwan",
};


--
2.43.0

2024-02-20 11:20:36

by Simon Horman

Subject: Re: [PATCH 01/12] net: usbnet: constify the struct device_type usage

On Sat, Feb 17, 2024 at 05:13:23PM -0300, Ricardo B. Marliere wrote:
> Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> core can properly handle constant struct device_type. Move the wlan_type
> and wwan_type variables to be constant structures as well, placing it into
> read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>

Reviewed-by: Simon Horman <[email protected]>