2024-02-18 08:00:30

by Ricardo B. Marliere

Subject: [PATCH 03/12] net: bridge: constify the struct device_type usage

Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
core can properly handle constant struct device_type. Move the br_type
variable to be a constant structure as well, placing it into read-only
memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Ricardo B. Marliere <[email protected]>
---
net/bridge/br_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c
index 717e9750614c..874cec75a818 100644
--- a/net/bridge/br_device.c
+++ b/net/bridge/br_device.c
@@ -474,7 +474,7 @@ static const struct net_device_ops br_netdev_ops = {
.ndo_fill_forward_path = br_fill_forward_path,
};

-static struct device_type br_type = {
+static const struct device_type br_type = {
.name = "bridge",
};


--
2.43.0

2024-02-20 11:20:59

by Simon Horman

Subject: Re: [PATCH 03/12] net: bridge: constify the struct device_type usage

On Sat, Feb 17, 2024 at 05:13:25PM -0300, Ricardo B. Marliere wrote:
> Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> core can properly handle constant struct device_type. Move the br_type
> variable to be a constant structure as well, placing it into read-only
> memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>

Reviewed-by: Simon Horman <[email protected]>