2024-02-17 19:21:09

by Aaro Koskinen

Subject: [PATCH] usb: gadget: omap_udc: fix USB gadget regression on Palm TE

When upgrading from 6.1 LTS to 6.6 LTS, I noticed the ethernet gadget
stopped working on Palm TE.

Commit 8825acd7cc8a ("ARM: omap1: remove dead code") deleted Palm TE from
machine_without_vbus_sense(), although the board is still used. Fix that.

Fixes: 8825acd7cc8a ("ARM: omap1: remove dead code")
Signed-off-by: Aaro Koskinen <[email protected]>
---
drivers/usb/gadget/udc/omap_udc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/omap_udc.c b/drivers/usb/gadget/udc/omap_udc.c
index 10c5d7f726a1..f90eeecf27de 100644
--- a/drivers/usb/gadget/udc/omap_udc.c
+++ b/drivers/usb/gadget/udc/omap_udc.c
@@ -2036,7 +2036,8 @@ static irqreturn_t omap_udc_iso_irq(int irq, void *_dev)

static inline int machine_without_vbus_sense(void)
{
- return machine_is_omap_osk() || machine_is_sx1();
+ return machine_is_omap_osk() || machine_is_omap_palmte() ||
+ machine_is_sx1();
}

static int omap_udc_start(struct usb_gadget *g,
--
2.39.2

2024-02-17 20:02:39

by Arnd Bergmann

Subject: Re: [PATCH] usb: gadget: omap_udc: fix USB gadget regression on Palm TE

On Sat, Feb 17, 2024, at 20:20, Aaro Koskinen wrote:
> When upgrading from 6.1 LTS to 6.6 LTS, I noticed the ethernet gadget
> stopped working on Palm TE.
>
> Commit 8825acd7cc8a ("ARM: omap1: remove dead code") deleted Palm TE from
> machine_without_vbus_sense(), although the board is still used. Fix that.
>
> Fixes: 8825acd7cc8a ("ARM: omap1: remove dead code")
> Signed-off-by: Aaro Koskinen <[email protected]>

Acked-by: Arnd Bergmann <[email protected]>

Sorry about that, I must have used the wrong regex while
searching for these while removing a lot of the other
palm variants.

Arnd