2024-02-20 05:24:53

by Li kunyu

[permalink] [raw]
Subject: [PATCH] exec: Delete unnecessary statements in remove_arg_zero()

'ret=0; ' In actual operation, the ret was not modified, so this
sentence can be removed.

Signed-off-by: Li kunyu <[email protected]>
---
fs/exec.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/exec.c b/fs/exec.c
index 7be0527f5ff25..10309a93d9c52 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -1747,7 +1747,6 @@ int remove_arg_zero(struct linux_binprm *bprm)

bprm->p++;
bprm->argc--;
- ret = 0;

out:
return ret;
--
2.18.2



2024-02-24 01:08:47

by Kees Cook

[permalink] [raw]
Subject: Re: [PATCH] exec: Delete unnecessary statements in remove_arg_zero()

On Tue, 20 Feb 2024 13:24:26 +0800, Li kunyu wrote:
> 'ret=0; ' In actual operation, the ret was not modified, so this
> sentence can be removed.
>
>

Applied to for-next/execve, thanks!

[1/1] exec: Delete unnecessary statements in remove_arg_zero()
https://git.kernel.org/kees/c/d3f0d7bbaefd

Take care,

--
Kees Cook