2024-02-20 06:21:28

by Li zeming

[permalink] [raw]
Subject: [PATCH] libfs: Remove unnecessary ‘0’ values from ret

ret is assigned first, so it does not need to initialize the assignment.

Signed-off-by: Li zeming <[email protected]>
---
fs/libfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/libfs.c b/fs/libfs.c
index eec6031b01554..6fb8244b259e8 100644
--- a/fs/libfs.c
+++ b/fs/libfs.c
@@ -1752,7 +1752,7 @@ static int generic_ci_d_hash(const struct dentry *dentry, struct qstr *str)
const struct inode *dir = READ_ONCE(dentry->d_inode);
struct super_block *sb = dentry->d_sb;
const struct unicode_map *um = sb->s_encoding;
- int ret = 0;
+ int ret;

if (!dir || !IS_CASEFOLDED(dir))
return 0;
--
2.18.2



2024-02-20 09:26:29

by Christian Brauner

[permalink] [raw]
Subject: Re: [PATCH] libfs: Remove unnecessary ‘0’ values from ret

On Tue, 20 Feb 2024 14:20:30 +0800, Li zeming wrote:
> ret is assigned first, so it does not need to initialize the assignment.
>
>

Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc

[1/1] libfs: Remove unnecessary ‘0’ values from ret
https://git.kernel.org/vfs/vfs/c/297ff2f5a0e4