2024-02-20 12:25:34

by Peter Griffin

Subject: [PATCH] tipc: fixup kerneldoc comment for struct tipc_node

Fixes the following warnings

linux/net/tipc/node.c:150: warning: Excess struct member 'inputq' description in 'tipc_node'
linux/net/tipc/node.c:150: warning: Excess struct member 'namedq' description in 'tipc_node'

Signed-off-by: Peter Griffin <[email protected]>
---
net/tipc/node.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/net/tipc/node.c b/net/tipc/node.c
index 3105abe97bb9..c1e890a82434 100644
--- a/net/tipc/node.c
+++ b/net/tipc/node.c
@@ -86,8 +86,6 @@ struct tipc_bclink_entry {
* @lock: rwlock governing access to structure
* @net: the applicable net namespace
* @hash: links to adjacent nodes in unsorted hash chain
- * @inputq: pointer to input queue containing messages for msg event
- * @namedq: pointer to name table input queue with name table messages
* @active_links: bearer ids of active links, used as index into links[] array
* @links: array containing references to all links to node
* @bc_entry: broadcast link entry
--
2.44.0.rc0.258.g7320e95886-goog

2024-02-20 20:01:21

by Randy Dunlap

Subject: Re: [PATCH] tipc: fixup kerneldoc comment for struct tipc_node

On 2/20/24 04:24, Peter Griffin wrote:
> Fixes the following warnings
>
> linux/net/tipc/node.c:150: warning: Excess struct member 'inputq' description in 'tipc_node'
> linux/net/tipc/node.c:150: warning: Excess struct member 'namedq' description in 'tipc_node'
>
> Signed-off-by: Peter Griffin <[email protected]>

i.e., same as
https://lore.kernel.org/lkml/[email protected]/

from Jan. 11, 2024....

Thanks.

> ---
> net/tipc/node.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/tipc/node.c b/net/tipc/node.c
> index 3105abe97bb9..c1e890a82434 100644
> --- a/net/tipc/node.c
> +++ b/net/tipc/node.c
> @@ -86,8 +86,6 @@ struct tipc_bclink_entry {
> * @lock: rwlock governing access to structure
> * @net: the applicable net namespace
> * @hash: links to adjacent nodes in unsorted hash chain
> - * @inputq: pointer to input queue containing messages for msg event
> - * @namedq: pointer to name table input queue with name table messages
> * @active_links: bearer ids of active links, used as index into links[] array
> * @links: array containing references to all links to node
> * @bc_entry: broadcast link entry

--
#Randy