2024-02-20 22:51:06

by Abel Vesa

Subject: [PATCH RFC 1/3] dt-bindings: display: msm: dp-controller: document X1E80100 compatible

Add the X1E80100 to the list of compatibles and docoment the is-edp
flag. This new flag will be used from now on to dictate the mode from
devicetree, instead of having separate compatibles for eDP and DP.

Signed-off-by: Abel Vesa <[email protected]>
---
Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
index ae53cbfb2193..ed11852e403d 100644
--- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
@@ -27,6 +27,7 @@ properties:
- qcom,sdm845-dp
- qcom,sm8350-dp
- qcom,sm8650-dp
+ - qcom,x1e80100-dp
- items:
- enum:
- qcom,sm8150-dp
@@ -73,6 +74,11 @@ properties:
- description: phy 0 parent
- description: phy 1 parent

+ is-edp:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description:
+ Tells the controller to switch to eDP mode
+
phys:
maxItems: 1


--
2.34.1

2024-02-22 03:32:43

by Bjorn Andersson

Subject: Re: [PATCH RFC 1/3] dt-bindings: display: msm: dp-controller: document X1E80100 compatible

On Wed, Feb 21, 2024 at 12:50:31AM +0200, Abel Vesa wrote:
> Add the X1E80100 to the list of compatibles and docoment the is-edp

s/docoment/document/

> flag. This new flag will be used from now on to dictate the mode from

s/from now on//

Perhaps cleaner to spell out that the controllers are expected to
operate in DP mode by default, and this flag can be used to select eDP
mode.

> devicetree, instead of having separate compatibles for eDP and DP.
>

Regards,
Bjorn

> Signed-off-by: Abel Vesa <[email protected]>
> ---
> Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> index ae53cbfb2193..ed11852e403d 100644
> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> @@ -27,6 +27,7 @@ properties:
> - qcom,sdm845-dp
> - qcom,sm8350-dp
> - qcom,sm8650-dp
> + - qcom,x1e80100-dp
> - items:
> - enum:
> - qcom,sm8150-dp
> @@ -73,6 +74,11 @@ properties:
> - description: phy 0 parent
> - description: phy 1 parent
>
> + is-edp:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + Tells the controller to switch to eDP mode
> +
> phys:
> maxItems: 1
>
>
> --
> 2.34.1
>