Switch to use dev_err_probe() to simplify the error path and
unify a message template.
Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/extcon/extcon-intel-mrfld.c | 18 ++++++------------
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/extcon/extcon-intel-mrfld.c b/drivers/extcon/extcon-intel-mrfld.c
index 2ee738f844ab..8414222d6597 100644
--- a/drivers/extcon/extcon-intel-mrfld.c
+++ b/drivers/extcon/extcon-intel-mrfld.c
@@ -250,24 +250,18 @@ static int mrfld_extcon_probe(struct platform_device *pdev)
return PTR_ERR(data->edev);
ret = devm_extcon_dev_register(dev, data->edev);
- if (ret < 0) {
- dev_err(dev, "can't register extcon device: %d\n", ret);
- return ret;
- }
+ if (ret < 0)
+ return dev_err_probe(dev, ret, "can't register extcon device\n");
ret = devm_request_threaded_irq(dev, irq, NULL, mrfld_extcon_interrupt,
IRQF_ONESHOT | IRQF_SHARED, pdev->name,
data);
- if (ret) {
- dev_err(dev, "can't register IRQ handler: %d\n", ret);
- return ret;
- }
+ if (ret)
+ return dev_err_probe(dev, ret, "can't register IRQ handler\n");
ret = regmap_read(regmap, BCOVE_ID, &id);
- if (ret) {
- dev_err(dev, "can't read PMIC ID: %d\n", ret);
- return ret;
- }
+ if (ret)
+ return dev_err_probe(dev, ret, "can't read PMIC ID\n");
data->id = id;
--
2.43.0.rc1.1.gbec44491f096
On Fri, Dec 22, 2023 at 06:19:54PM +0200, Andy Shevchenko wrote:
> Switch to use dev_err_probe() to simplify the error path and
> unify a message template.
Any comments? Can these two patches (with
[email protected]) be applied?
--
With Best Regards,
Andy Shevchenko
On Thu, Feb 01, 2024 at 02:09:23PM +0200, Andy Shevchenko wrote:
> On Fri, Dec 22, 2023 at 06:19:54PM +0200, Andy Shevchenko wrote:
> > Switch to use dev_err_probe() to simplify the error path and
> > unify a message template.
>
> Any comments? Can these two patches (with
> [email protected]) be applied?
Ping?
It's more than two months passed...
--
With Best Regards,
Andy Shevchenko
>
>---------Original Message---------
>Sender: Andy Shevchenko <[email protected]>
>Date: 2024-02-21 23:52 (GMT+9)
>Title: Re: [PATCH v1 1/1] extcon: intel-mrfld: Switch to use dev_err_probe()
>
>On Thu, Feb 01, 2024 at 02:09:23PM +0200, Andy Shevchenko wrote:
>> On Fri, Dec 22, 2023 at 06:19:54PM +0200, Andy Shevchenko wrote:
>> > Switch to use dev_err_probe() to simplify the error path and
>> > unify a message template.
>>
>> Any comments? Can these two patches (with
>> [email protected]) be applied?
>
>Ping?
>
>It's more than two months passed...
The patch "extcon: intel-mrfld: Switch to use dev_err_probe()"
looked good to me.
Chanwoo, please take a look.
Acked-by: MyungJoo Ham <[email protected]>
> -----Original Message-----
> From: Andy Shevchenko <[email protected]>
> Sent: Wednesday, February 21, 2024 11:53 PM
> To: [email protected]
> Cc: MyungJoo Ham <[email protected]>; Chanwoo Choi
> <[email protected]>
> Subject: Re: [PATCH v1 1/1] extcon: intel-mrfld: Switch to use
dev_err_probe()
>
> On Thu, Feb 01, 2024 at 02:09:23PM +0200, Andy Shevchenko wrote:
> > On Fri, Dec 22, 2023 at 06:19:54PM +0200, Andy Shevchenko wrote:
> > > Switch to use dev_err_probe() to simplify the error path and unify a
> > > message template.
> >
> > Any comments? Can these two patches (with
> > [email protected]) be applied?
>
> Ping?
>
> It's more than two months passed...
>
I'm sorry for late reply. I applied it. Thanks.
Best Regards,
Chanwoo Choi
On Thu, Feb 22, 2024 at 02:45:51PM +0900, Chanwoo Choi wrote:
> > -----Original Message-----
> > From: Andy Shevchenko <[email protected]>
> > Sent: Wednesday, February 21, 2024 11:53 PM
> > On Thu, Feb 01, 2024 at 02:09:23PM +0200, Andy Shevchenko wrote:
> > > On Fri, Dec 22, 2023 at 06:19:54PM +0200, Andy Shevchenko wrote:
> > > > Switch to use dev_err_probe() to simplify the error path and unify a
> > > > message template.
> > >
> > > Any comments? Can these two patches (with
> > > [email protected]) be applied?
> >
> > Ping?
> >
> > It's more than two months passed...
>
> I'm sorry for late reply. I applied it. Thanks.
Thank you, there is the other one. Can it be applied too?
--
With Best Regards,
Andy Shevchenko