2024-02-22 10:12:57

by Théo Lebrun

Subject: [PATCH v4 3/4] spi: cadence-qspi: put runtime in runtime PM hooks names

Follow kernel naming convention with regards to power-management
callback function names.

The convention in the kernel is:
- prefix_suspend means the system-wide suspend callback;
- prefix_runtime_suspend means the runtime PM suspend callback.
The same applies to resume callbacks.

Signed-off-by: Théo Lebrun <[email protected]>
---
drivers/spi/spi-cadence-quadspi.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
index 809bbbb876ad..ee14965142ba 100644
--- a/drivers/spi/spi-cadence-quadspi.c
+++ b/drivers/spi/spi-cadence-quadspi.c
@@ -1927,7 +1927,7 @@ static void cqspi_remove(struct platform_device *pdev)
pm_runtime_disable(&pdev->dev);
}

-static int cqspi_suspend(struct device *dev)
+static int cqspi_runtime_suspend(struct device *dev)
{
struct cqspi_st *cqspi = dev_get_drvdata(dev);

@@ -1936,7 +1936,7 @@ static int cqspi_suspend(struct device *dev)
return 0;
}

-static int cqspi_resume(struct device *dev)
+static int cqspi_runtime_resume(struct device *dev)
{
struct cqspi_st *cqspi = dev_get_drvdata(dev);

@@ -1949,8 +1949,8 @@ static int cqspi_resume(struct device *dev)
return 0;
}

-static DEFINE_RUNTIME_DEV_PM_OPS(cqspi_dev_pm_ops, cqspi_suspend,
- cqspi_resume, NULL);
+static DEFINE_RUNTIME_DEV_PM_OPS(cqspi_dev_pm_ops, cqspi_runtime_suspend,
+ cqspi_runtime_resume, NULL);

static const struct cqspi_driver_platdata cdns_qspi = {
.quirks = CQSPI_DISABLE_DAC_MODE,

--
2.43.2

2024-02-22 10:28:39

by Dhruva Gole

Subject: Re: [PATCH v4 3/4] spi: cadence-qspi: put runtime in runtime PM hooks names

Hi,

On Feb 22, 2024 at 11:12:31 +0100, Th?o Lebrun wrote:
> Follow kernel naming convention with regards to power-management
> callback function names.
>
> The convention in the kernel is:
> - prefix_suspend means the system-wide suspend callback;
> - prefix_runtime_suspend means the runtime PM suspend callback.
> The same applies to resume callbacks.
>
> Signed-off-by: Th?o Lebrun <[email protected]>
> ---

LGTM!

Reviewed-by: Dhruva Gole <[email protected]>



--
Best regards,
Dhruva Gole <[email protected]>