On Thu, Feb 22, 2024 at 01:07:41PM +0200, Dumitru Ceclan wrote:
> The AD7173 family offer a complete integrated Sigma-Delta ADC solution
> which can be used in high precision, low noise single channel applications
> or higher speed multiplexed applications. The Sigma-Delta ADC is intended
> primarily for measurement of signals close to DC but also delivers
> outstanding performance with input bandwidths out to ~10kHz.
>
> Signed-off-by: Dumitru Ceclan <[email protected]>
> ---
> V13->V14
I gave you an R-b tag on v13, conditional on the descriptions.
Why didn't you take it? The only other relevant change is the added
restriction on channel reg. Is that the reason you didn't take or was
there smething else.
Cheers,
Conor.
> - Refer in descriptions of the avdd-supply as AVDD1 in concordance to datasheet
> - Fix typo
> - Place interrupts descriptions separately for each item
> - Restrict max channel reg to 3 for models AD717x-2
On 22/02/2024 17:50, Conor Dooley wrote:
> On Thu, Feb 22, 2024 at 01:07:41PM +0200, Dumitru Ceclan wrote:
>> V13->V14
>
> I gave you an R-b tag on v13, conditional on the descriptions.
> Why didn't you take it? The only other relevant change is the added
> restriction on channel reg. Is that the reason you didn't take or was
> there smething else.
>
Just that change. Should I consider that change minor enough to include
a previous R-b tag?
On Fri, Feb 23, 2024 at 11:12:21AM +0200, Ceclan, Dumitru wrote:
> On 22/02/2024 17:50, Conor Dooley wrote:
> > On Thu, Feb 22, 2024 at 01:07:41PM +0200, Dumitru Ceclan wrote:
>
>
> >> V13->V14
> >
> > I gave you an R-b tag on v13, conditional on the descriptions.
> > Why didn't you take it? The only other relevant change is the added
> > restriction on channel reg. Is that the reason you didn't take or was
> > there smething else.
> >
>
> Just that change. Should I consider that change minor enough to include
> a previous R-b tag?
Yah, you coulda.
Reviewed-by: Conor Dooley <[email protected]>
Cheers,
Conor.