2024-02-08 09:26:54

by Kemeng Shi

Subject: [PATCH 7/7] fs/writeback: remove unnecessary return in writeback_inodes_sb

writeback_inodes_sb doesn't have return value, just remove unnecessary
return in it.

Signed-off-by: Kemeng Shi <[email protected]>
---
fs/fs-writeback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index 816505d74b2f..eb62196777dd 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -2748,7 +2748,7 @@ EXPORT_SYMBOL(writeback_inodes_sb_nr);
*/
void writeback_inodes_sb(struct super_block *sb, enum wb_reason reason)
{
- return writeback_inodes_sb_nr(sb, get_nr_dirty_pages(), reason);
+ writeback_inodes_sb_nr(sb, get_nr_dirty_pages(), reason);
}
EXPORT_SYMBOL(writeback_inodes_sb);

--
2.30.0

2024-02-23 14:00:09

by Jan Kara

Subject: Re: [PATCH 7/7] fs/writeback: remove unnecessary return in writeback_inodes_sb

On Fri 09-02-24 01:20:24, Kemeng Shi wrote:
> writeback_inodes_sb doesn't have return value, just remove unnecessary
> return in it.
>
> Signed-off-by: Kemeng Shi <[email protected]>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <[email protected]>

Honza

> ---
> fs/fs-writeback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index 816505d74b2f..eb62196777dd 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -2748,7 +2748,7 @@ EXPORT_SYMBOL(writeback_inodes_sb_nr);
> */
> void writeback_inodes_sb(struct super_block *sb, enum wb_reason reason)
> {
> - return writeback_inodes_sb_nr(sb, get_nr_dirty_pages(), reason);
> + writeback_inodes_sb_nr(sb, get_nr_dirty_pages(), reason);
> }
> EXPORT_SYMBOL(writeback_inodes_sb);
>
> --
> 2.30.0
>
--
Jan Kara <[email protected]>
SUSE Labs, CR