2024-02-23 18:17:26

by Aaro Koskinen

Subject: [PATCH] ARM: OMAP: fix USB regression on Nokia N8x0

GPIO chip labels are wrong for OMAP2, so the USB does not work. Fix.

Fixes: 8e0285ab95a9 ("ARM/musb: omap2: Remove global GPIO numbers from TUSB6010")
Signed-off-by: Aaro Koskinen <[email protected]>
---
arch/arm/mach-omap2/board-n8x0.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mach-omap2/board-n8x0.c b/arch/arm/mach-omap2/board-n8x0.c
index 31755a378c73..2c91148c1b39 100644
--- a/arch/arm/mach-omap2/board-n8x0.c
+++ b/arch/arm/mach-omap2/board-n8x0.c
@@ -79,10 +79,8 @@ static struct musb_hdrc_platform_data tusb_data = {
static struct gpiod_lookup_table tusb_gpio_table = {
.dev_id = "musb-tusb",
.table = {
- GPIO_LOOKUP("gpio-0-15", 0, "enable",
- GPIO_ACTIVE_HIGH),
- GPIO_LOOKUP("gpio-48-63", 10, "int",
- GPIO_ACTIVE_HIGH),
+ GPIO_LOOKUP("gpio-0-31", 0, "enable", GPIO_ACTIVE_HIGH),
+ GPIO_LOOKUP("gpio-32-63", 26, "int", GPIO_ACTIVE_HIGH),
{ }
},
};
--
2.39.2

2024-02-23 20:49:04

by Linus Walleij

Subject: Re: [PATCH] ARM: OMAP: fix USB regression on Nokia N8x0

On Fri, Feb 23, 2024 at 7:17 PM Aaro Koskinen <[email protected]> wrote:

> GPIO chip labels are wrong for OMAP2, so the USB does not work. Fix.
>
> Fixes: 8e0285ab95a9 ("ARM/musb: omap2: Remove global GPIO numbers from TUSB6010")
> Signed-off-by: Aaro Koskinen <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij