2024-02-24 11:41:57

by Srinivas Kandagatla

[permalink] [raw]
Subject: [PATCH 0/1] slimbus: fixes for v6.8

From: Srinivas Kandagatla <[email protected]>

Here are one fix in slimbus for 6.8, Could you queue
these for next possible rc.

This patch fixes one off bug in range of logical address assigned to the
device, which is why am sending for v6.8 rather than next release.

Thanks,
Srini

Christophe JAILLET (1):
slimbus: core: Remove usage of the deprecated ida_simple_xx() API

drivers/slimbus/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--
2.25.1



2024-02-24 11:42:10

by Srinivas Kandagatla

[permalink] [raw]
Subject: [PATCH 1/1] slimbus: core: Remove usage of the deprecated ida_simple_xx() API

From: Christophe JAILLET <[email protected]>

ida_alloc() and ida_free() should be preferred to the deprecated
ida_simple_get() and ida_simple_remove().

Note that the upper limit of ida_simple_get() is exclusive, but the one of
ida_alloc_range() is inclusive. So change this change allows one more
device. Previously address 0xFE was never used.

Fixes: 46a2bb5a7f7e ("slimbus: core: Add slim controllers support")
Cc: <[email protected]>
Signed-off-by: Christophe JAILLET <[email protected]>
Signed-off-by: Srinivas Kandagatla <[email protected]>
---
drivers/slimbus/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c
index d43873bb5fe6..01cbd4621981 100644
--- a/drivers/slimbus/core.c
+++ b/drivers/slimbus/core.c
@@ -436,8 +436,8 @@ static int slim_device_alloc_laddr(struct slim_device *sbdev,
if (ret < 0)
goto err;
} else if (report_present) {
- ret = ida_simple_get(&ctrl->laddr_ida,
- 0, SLIM_LA_MANAGER - 1, GFP_KERNEL);
+ ret = ida_alloc_max(&ctrl->laddr_ida,
+ SLIM_LA_MANAGER - 1, GFP_KERNEL);
if (ret < 0)
goto err;

--
2.25.1