2024-02-25 20:25:59

by Krzysztof Kozlowski

Subject: [PATCH 1/2] soc: qcom: geni-se: drop unused kerneldoc struct geni_wrapper param

Drop description of non-existing 'struct geni_wrapper' member:

qcom-geni-se.c:99: warning: Excess struct member 'to_core' description in 'geni_wrapper'

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/soc/qcom/qcom-geni-se.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c
index bdcf44b85b2f..2e8f24d5da80 100644
--- a/drivers/soc/qcom/qcom-geni-se.c
+++ b/drivers/soc/qcom/qcom-geni-se.c
@@ -89,7 +89,6 @@
* @base: Base address of this instance of QUP wrapper core
* @clks: Handle to the primary & optional secondary AHB clocks
* @num_clks: Count of clocks
- * @to_core: Core ICC path
*/
struct geni_wrapper {
struct device *dev;
--
2.34.1

2024-02-25 20:26:07

by Krzysztof Kozlowski

Subject: [PATCH 2/2] soc: qcom: aoss: add missing kerneldoc for qmp members

Add missing kerneldoc to silence:

qcom_aoss.c:93: warning: Function parameter or struct member 'debugfs_root' not described in 'qmp'
qcom_aoss.c:93: warning: Function parameter or struct member 'debugfs_files' not described in 'qmp'

Fixes: d51d984c5525 ("soc: qcom: aoss: Add debugfs interface for sending messages")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/soc/qcom/qcom_aoss.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
index e8ae8aa6391f..ca2f6b7629ce 100644
--- a/drivers/soc/qcom/qcom_aoss.c
+++ b/drivers/soc/qcom/qcom_aoss.c
@@ -71,6 +71,8 @@ struct qmp_cooling_device {
* @tx_lock: provides synchronization between multiple callers of qmp_send()
* @qdss_clk: QDSS clock hw struct
* @cooling_devs: thermal cooling devices
+ * @debugfs_root: directory for the developer/tester interface
+ * @debugfs_files: array of individual debugfs entries under debugfs_root
*/
struct qmp {
void __iomem *msgram;
--
2.34.1

2024-02-25 20:47:08

by Dmitry Baryshkov

Subject: Re: [PATCH 1/2] soc: qcom: geni-se: drop unused kerneldoc struct geni_wrapper param

On Sun, 25 Feb 2024 at 22:25, Krzysztof Kozlowski
<[email protected]> wrote:
>
> Drop description of non-existing 'struct geni_wrapper' member:
>
> qcom-geni-se.c:99: warning: Excess struct member 'to_core' description in 'geni_wrapper'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/soc/qcom/qcom-geni-se.c | 1 -
> 1 file changed, 1 deletion(-)

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2024-02-25 20:47:23

by Dmitry Baryshkov

Subject: Re: [PATCH 2/2] soc: qcom: aoss: add missing kerneldoc for qmp members

On Sun, 25 Feb 2024 at 22:26, Krzysztof Kozlowski
<[email protected]> wrote:
>
> Add missing kerneldoc to silence:
>
> qcom_aoss.c:93: warning: Function parameter or struct member 'debugfs_root' not described in 'qmp'
> qcom_aoss.c:93: warning: Function parameter or struct member 'debugfs_files' not described in 'qmp'
>
> Fixes: d51d984c5525 ("soc: qcom: aoss: Add debugfs interface for sending messages")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/soc/qcom/qcom_aoss.c | 2 ++
> 1 file changed, 2 insertions(+)
>

Reviewed-by: Dmitry Baryshkov <[email protected]>


--
With best wishes
Dmitry

2024-03-04 21:24:51

by Bjorn Andersson

Subject: Re: (subset) [PATCH 1/2] soc: qcom: geni-se: drop unused kerneldoc struct geni_wrapper param

On Sun, 25 Feb 2024 21:25:44 +0100, Krzysztof Kozlowski wrote:
> Drop description of non-existing 'struct geni_wrapper' member:
>
> qcom-geni-se.c:99: warning: Excess struct member 'to_core' description in 'geni_wrapper'
>
>

Applied, thanks!

[1/2] soc: qcom: geni-se: drop unused kerneldoc struct geni_wrapper param
commit: 87edd944ff568fe923530b3b15fe96380d4442e3
[2/2] soc: qcom: aoss: add missing kerneldoc for qmp members
commit: 9f378a62164cfe218b5a355696464d93b132edfb

Best regards,
--
Bjorn Andersson <[email protected]>