2024-02-25 23:16:35

by Andreas Kemnade

Subject: [PATCH] ARM: dts: imx6: fix IRQ config of RC5T619

Set interrupt type to level low to correctly describe the hardware and
do not rely on the driver to do the right thing.

Signed-off-by: Andreas Kemnade <[email protected]>
---
arch/arm/boot/dts/nxp/imx/e60k02.dtsi | 2 +-
arch/arm/boot/dts/nxp/imx/e70k02.dtsi | 2 +-
arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/e60k02.dtsi b/arch/arm/boot/dts/nxp/imx/e60k02.dtsi
index dd03e3860f97f..13756d39fb7b9 100644
--- a/arch/arm/boot/dts/nxp/imx/e60k02.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/e60k02.dtsi
@@ -127,7 +127,7 @@ ricoh619: pmic@32 {
compatible = "ricoh,rc5t619";
reg = <0x32>;
interrupt-parent = <&gpio5>;
- interrupts = <11 IRQ_TYPE_EDGE_FALLING>;
+ interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
system-power-controller;

regulators {
diff --git a/arch/arm/boot/dts/nxp/imx/e70k02.dtsi b/arch/arm/boot/dts/nxp/imx/e70k02.dtsi
index 4e1bf080eaca0..dcc3c9d488a88 100644
--- a/arch/arm/boot/dts/nxp/imx/e70k02.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/e70k02.dtsi
@@ -145,7 +145,7 @@ ricoh619: pmic@32 {
compatible = "ricoh,rc5t619";
reg = <0x32>;
interrupt-parent = <&gpio4>;
- interrupts = <19 IRQ_TYPE_EDGE_FALLING>;
+ interrupts = <19 IRQ_TYPE_LEVEL_LOW>;
system-power-controller;

regulators {
diff --git a/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts b/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts
index 922749bf11bc1..04027627fe62b 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts
@@ -161,7 +161,7 @@ ricoh619: pmic@32 {
pinctrl-0 = <&pinctrl_ricoh_gpio>;
reg = <0x32>;
interrupt-parent = <&gpio5>;
- interrupts = <11 IRQ_TYPE_EDGE_FALLING>;
+ interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
system-power-controller;

regulators {
--
2.39.2

2024-03-28 06:51:27

by Shawn Guo

Subject: Re: [PATCH] ARM: dts: imx6: fix IRQ config of RC5T619

On Sun, Feb 25, 2024 at 11:57:20PM +0100, Andreas Kemnade wrote:
> Set interrupt type to level low to correctly describe the hardware and
> do not rely on the driver to do the right thing.
>
> Signed-off-by: Andreas Kemnade <[email protected]>

Applied, thanks!