2024-02-26 19:16:58

by Martin Kaiser

Subject: [PATCH 0/3] lib/test_vmalloc.c: three trivial fixes

Here's three trivial changes to fix a typo, address a checkpatch warning and
remove an unused function.

Martin Kaiser (3):
lib/test_vmalloc.c: fix typo in function name
lib/test_vmalloc.c: drop empty exit function
lib/test_vmalloc.c: use unsigned long constant

lib/test_vmalloc.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)

--
2.39.2

2024-02-26 19:17:07

by Martin Kaiser

Subject: [PATCH 1/3] lib/test_vmalloc.c: fix typo in function name

Fix a typo and change the function name to init_test_configuration. Both
caller and definition have the same typo, so the current code already
works.

Signed-off-by: Martin Kaiser <[email protected]>
---
lib/test_vmalloc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c
index 3718d9886407..191b6bd5dff9 100644
--- a/lib/test_vmalloc.c
+++ b/lib/test_vmalloc.c
@@ -501,7 +501,7 @@ static int test_func(void *private)
}

static int
-init_test_configurtion(void)
+init_test_configuration(void)
{
/*
* A maximum number of workers is defined as hard-coded
@@ -531,7 +531,7 @@ static void do_concurrent_test(void)
/*
* Set some basic configurations plus sanity check.
*/
- ret = init_test_configurtion();
+ ret = init_test_configuration();
if (ret < 0)
return;

--
2.39.2

2024-02-27 06:59:14

by Uladzislau Rezki

Subject: Re: [PATCH 1/3] lib/test_vmalloc.c: fix typo in function name

On Mon, Feb 26, 2024 at 08:11:57PM +0100, Martin Kaiser wrote:
> Fix a typo and change the function name to init_test_configuration. Both
> caller and definition have the same typo, so the current code already
> works.
>
> Signed-off-by: Martin Kaiser <[email protected]>
> ---
> lib/test_vmalloc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c
> index 3718d9886407..191b6bd5dff9 100644
> --- a/lib/test_vmalloc.c
> +++ b/lib/test_vmalloc.c
> @@ -501,7 +501,7 @@ static int test_func(void *private)
> }
>
> static int
> -init_test_configurtion(void)
> +init_test_configuration(void)
> {
> /*
> * A maximum number of workers is defined as hard-coded
> @@ -531,7 +531,7 @@ static void do_concurrent_test(void)
> /*
> * Set some basic configurations plus sanity check.
> */
> - ret = init_test_configurtion();
> + ret = init_test_configuration();
> if (ret < 0)
> return;
>
> --
> 2.39.2
>
Reviewed-by: Uladzislau Rezki (Sony) <[email protected]>

--
Uladzislau Rezki