2024-02-27 19:07:04

by William Zhang

Subject: [PATCH] mtd: rawnand: brcmnand: fix sparse warnings

Fix the following sparse warnings:
sparse warnings: (new ones prefixed by >>)
>> drivers/mtd/nand/raw/brcmnand/bcmbca_nand.c:79:41: sparse: sparse:
cast removes address space '__iomem' of expression
drivers/mtd/nand/raw/brcmnand/bcmbca_nand.c:80:17: sparse: sparse:
cast removes address space '__iomem' of expression
drivers/mtd/nand/raw/brcmnand/bcmbca_nand.c:80:17: sparse: sparse:
cast removes address space '__iomem' of expression
drivers/mtd/nand/raw/brcmnand/bcmbca_nand.c:80:17: sparse: sparse:
cast removes address space '__iomem' of expression

Fixes: c52c16d1bee5 ("mtd: rawnand: brcmnand: Add BCMBCA read data bus interface")
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: William Zhang <[email protected]>

---

drivers/mtd/nand/raw/brcmnand/bcmbca_nand.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/raw/brcmnand/bcmbca_nand.c b/drivers/mtd/nand/raw/brcmnand/bcmbca_nand.c
index 7ad3e7a98f97..ea534850b97a 100644
--- a/drivers/mtd/nand/raw/brcmnand/bcmbca_nand.c
+++ b/drivers/mtd/nand/raw/brcmnand/bcmbca_nand.c
@@ -76,8 +76,8 @@ static void bcmbca_read_data_bus(struct brcmnand_soc *soc,
* and dest address, which is incompatible with nand cache. Fallback
* to the memcpy_fromio in such case
*/
- if (bcmbca_nand_is_buf_aligned((void *)flash_cache, buffer))
- memcpy((void *)buffer, (void *)flash_cache, fc_words * 4);
+ if (bcmbca_nand_is_buf_aligned((void __force *)flash_cache, buffer))
+ memcpy((void *)buffer, (void __force *)flash_cache, fc_words * 4);
else
memcpy_fromio((void *)buffer, flash_cache, fc_words * 4);
}
--
2.37.3

2024-03-07 17:34:39

by Miquel Raynal

Subject: Re: [PATCH] mtd: rawnand: brcmnand: fix sparse warnings

On Tue, 2024-02-27 at 19:02:57 UTC, William Zhang wrote:
> Fix the following sparse warnings:
> sparse warnings: (new ones prefixed by >>)
> >> drivers/mtd/nand/raw/brcmnand/bcmbca_nand.c:79:41: sparse: sparse:
> cast removes address space '__iomem' of expression
> drivers/mtd/nand/raw/brcmnand/bcmbca_nand.c:80:17: sparse: sparse:
> cast removes address space '__iomem' of expression
> drivers/mtd/nand/raw/brcmnand/bcmbca_nand.c:80:17: sparse: sparse:
> cast removes address space '__iomem' of expression
> drivers/mtd/nand/raw/brcmnand/bcmbca_nand.c:80:17: sparse: sparse:
> cast removes address space '__iomem' of expression
>
> Fixes: c52c16d1bee5 ("mtd: rawnand: brcmnand: Add BCMBCA read data bus interface")
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: William Zhang <[email protected]>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel