2024-02-28 03:41:09

by Kunwu Chan

Subject: [PATCH v2] bus: mhi: ep: Simplify the allocation of slab caches in mhi_ep_register_controller

Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
to simplify the creation of SLAB caches.

Signed-off-by: Kunwu Chan <[email protected]>
---
v2:
- Simplify the allocations of mhi_ring_element slab caches
---
drivers/bus/mhi/ep/main.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c
index 65fc1d738bec..795611482f16 100644
--- a/drivers/bus/mhi/ep/main.c
+++ b/drivers/bus/mhi/ep/main.c
@@ -1478,9 +1478,7 @@ int mhi_ep_register_controller(struct mhi_ep_cntrl *mhi_cntrl,
goto err_free_ch;
}

- mhi_cntrl->ev_ring_el_cache = kmem_cache_create("mhi_ep_event_ring_el",
- sizeof(struct mhi_ring_element), 0,
- SLAB_CACHE_DMA, NULL);
+ mhi_cntrl->ev_ring_el_cache = KMEM_CACHE(mhi_ring_element, SLAB_CACHE_DMA);
if (!mhi_cntrl->ev_ring_el_cache) {
ret = -ENOMEM;
goto err_free_cmd;
@@ -1493,9 +1491,7 @@ int mhi_ep_register_controller(struct mhi_ep_cntrl *mhi_cntrl,
goto err_destroy_ev_ring_el_cache;
}

- mhi_cntrl->ring_item_cache = kmem_cache_create("mhi_ep_ring_item",
- sizeof(struct mhi_ep_ring_item), 0,
- 0, NULL);
+ mhi_cntrl->ring_item_cache = KMEM_CACHE(mhi_ep_ring_item, 0);
if (!mhi_cntrl->ev_ring_el_cache) {
ret = -ENOMEM;
goto err_destroy_tre_buf_cache;
--
2.39.2

2024-03-19 16:35:58

by Manivannan Sadhasivam

Subject: Re: [PATCH v2] bus: mhi: ep: Simplify the allocation of slab caches in mhi_ep_register_controller

On Wed, Feb 28, 2024 at 11:00:56AM +0800, Kunwu Chan wrote:
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
>

There are 3 kmem caches in this driver. Please change all of them.

- Mani

> Signed-off-by: Kunwu Chan <[email protected]>
> ---
> v2:
> - Simplify the allocations of mhi_ring_element slab caches
> ---
> drivers/bus/mhi/ep/main.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c
> index 65fc1d738bec..795611482f16 100644
> --- a/drivers/bus/mhi/ep/main.c
> +++ b/drivers/bus/mhi/ep/main.c
> @@ -1478,9 +1478,7 @@ int mhi_ep_register_controller(struct mhi_ep_cntrl *mhi_cntrl,
> goto err_free_ch;
> }
>
> - mhi_cntrl->ev_ring_el_cache = kmem_cache_create("mhi_ep_event_ring_el",
> - sizeof(struct mhi_ring_element), 0,
> - SLAB_CACHE_DMA, NULL);
> + mhi_cntrl->ev_ring_el_cache = KMEM_CACHE(mhi_ring_element, SLAB_CACHE_DMA);
> if (!mhi_cntrl->ev_ring_el_cache) {
> ret = -ENOMEM;
> goto err_free_cmd;
> @@ -1493,9 +1491,7 @@ int mhi_ep_register_controller(struct mhi_ep_cntrl *mhi_cntrl,
> goto err_destroy_ev_ring_el_cache;
> }
>
> - mhi_cntrl->ring_item_cache = kmem_cache_create("mhi_ep_ring_item",
> - sizeof(struct mhi_ep_ring_item), 0,
> - 0, NULL);
> + mhi_cntrl->ring_item_cache = KMEM_CACHE(mhi_ep_ring_item, 0);
> if (!mhi_cntrl->ev_ring_el_cache) {
> ret = -ENOMEM;
> goto err_destroy_tre_buf_cache;
> --
> 2.39.2
>

--
மணிவண்ணன் சதாசிவம்