2024-02-28 03:56:51

by Jiapeng Chong

Subject: [PATCH 1/2] xfs: Remove duplicate include

/fs/xfs/xfs_qm_bhv.c: xfs_mount.h is included more than once.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8386
Signed-off-by: Jiapeng Chong <[email protected]>
---
fs/xfs/xfs_qm_bhv.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_qm_bhv.c b/fs/xfs/xfs_qm_bhv.c
index 271c1021c733..a11436579877 100644
--- a/fs/xfs/xfs_qm_bhv.c
+++ b/fs/xfs/xfs_qm_bhv.c
@@ -11,7 +11,6 @@
#include "xfs_trans_resv.h"
#include "xfs_mount.h"
#include "xfs_quota.h"
-#include "xfs_mount.h"
#include "xfs_inode.h"
#include "xfs_trans.h"
#include "xfs_qm.h"
--
2.20.1.7.g153144c

2024-02-28 04:01:43

by Darrick J. Wong

Subject: Re: [PATCH 1/2] xfs: Remove duplicate include

On Wed, Feb 28, 2024 at 11:56:11AM +0800, Jiapeng Chong wrote:
> ./fs/xfs/xfs_qm_bhv.c: xfs_mount.h is included more than once.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8386
> Signed-off-by: Jiapeng Chong <[email protected]>

Looks good,
Reviewed-by: Darrick J. Wong <[email protected]>

--D

> ---
> fs/xfs/xfs_qm_bhv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_qm_bhv.c b/fs/xfs/xfs_qm_bhv.c
> index 271c1021c733..a11436579877 100644
> --- a/fs/xfs/xfs_qm_bhv.c
> +++ b/fs/xfs/xfs_qm_bhv.c
> @@ -11,7 +11,6 @@
> #include "xfs_trans_resv.h"
> #include "xfs_mount.h"
> #include "xfs_quota.h"
> -#include "xfs_mount.h"
> #include "xfs_inode.h"
> #include "xfs_trans.h"
> #include "xfs_qm.h"
> --
> 2.20.1.7.g153144c
>
>

2024-02-28 04:10:27

by Jiapeng Chong

Subject: [PATCH 2/2] xfs: Remove duplicate include

/fs/xfs/xfs_trace.c: xfs_bmap.h is included more than once.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8385
Signed-off-by: Jiapeng Chong <[email protected]>
---
fs/xfs/xfs_trace.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_trace.c b/fs/xfs/xfs_trace.c
index 1a963382e5e9..23e906b60f21 100644
--- a/fs/xfs/xfs_trace.c
+++ b/fs/xfs/xfs_trace.c
@@ -17,7 +17,6 @@
#include "xfs_btree.h"
#include "xfs_da_btree.h"
#include "xfs_alloc.h"
-#include "xfs_bmap.h"
#include "xfs_attr.h"
#include "xfs_trans.h"
#include "xfs_log.h"
--
2.20.1.7.g153144c