2024-02-04 12:57:37

by Masahiro Yamada

Subject: [PATCH] arm: omap1: remove duplicated 'select ARCH_OMAP'

Commit 980a637d11fe ("ARM: omap1: fix !ARCH_OMAP1_ANY link failures")
added one more 'select ARCH_OMAP'.

Signed-off-by: Masahiro Yamada <[email protected]>
---

arch/arm/mach-omap1/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-omap1/Kconfig b/arch/arm/mach-omap1/Kconfig
index cbf703f0d850..a643b71e30a3 100644
--- a/arch/arm/mach-omap1/Kconfig
+++ b/arch/arm/mach-omap1/Kconfig
@@ -4,7 +4,6 @@ menuconfig ARCH_OMAP1
depends on ARCH_MULTI_V4T || ARCH_MULTI_V5
depends on CPU_LITTLE_ENDIAN
depends on ATAGS
- select ARCH_OMAP
select ARCH_HAS_HOLES_MEMORYMODEL
select ARCH_OMAP
select CLKSRC_MMIO
--
2.40.1

2024-02-04 13:19:46

by Masahiro Yamada

Subject: Re: [PATCH] arm: omap1: remove duplicated 'select ARCH_OMAP'

Just a nit.

The commit subject "arm:" should be capitalized to "ARM:"
because it is a convention for changes under arch/arm/.

Maybe, the maintainer can cater to it?


On Sun, Feb 4, 2024 at 9:57 PM Masahiro Yamada <[email protected]> wrote:
>
> Commit 980a637d11fe ("ARM: omap1: fix !ARCH_OMAP1_ANY link failures")
> added one more 'select ARCH_OMAP'.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> arch/arm/mach-omap1/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap1/Kconfig b/arch/arm/mach-omap1/Kconfig
> index cbf703f0d850..a643b71e30a3 100644
> --- a/arch/arm/mach-omap1/Kconfig
> +++ b/arch/arm/mach-omap1/Kconfig
> @@ -4,7 +4,6 @@ menuconfig ARCH_OMAP1
> depends on ARCH_MULTI_V4T || ARCH_MULTI_V5
> depends on CPU_LITTLE_ENDIAN
> depends on ATAGS
> - select ARCH_OMAP
> select ARCH_HAS_HOLES_MEMORYMODEL
> select ARCH_OMAP
> select CLKSRC_MMIO
> --
> 2.40.1
>


--
Best Regards
Masahiro Yamada

2024-02-28 07:28:43

by Tony Lindgren

Subject: Re: [PATCH] arm: omap1: remove duplicated 'select ARCH_OMAP'

* Masahiro Yamada <[email protected]> [240204 13:19]:
> Just a nit.
>
> The commit subject "arm:" should be capitalized to "ARM:"
> because it is a convention for changes under arch/arm/.
>
> Maybe, the maintainer can cater to it?

Thanks yes applying into omap-for-v6.9/omap1 with the prefix
changed.

Regards,

Tony