2024-02-28 12:38:43

by Alisa-Dariana Roman

[permalink] [raw]
Subject: [PATCH v4 0/4] iio: adc: ad7192: Add support for AD7194

From: romandariana <[email protected]>

Dear maintainers,

Thank you all for the feedback!

I am submitting the upgraded series of patches for the ad7192 driver.

Please consider applying in order.

Thank you!

v3 -> v4
- drop device properties patch, changes already applied to tree
- change bindings and driver such that for AD7194 there are 16
differential channels, by default set to AINx - AINCOM, which can be
configured in devicetree however the user likes
- corrected mistake regarding positive and negative channel macros:
subtract 1 from the number corresponding to AIN input

v2 -> v3
- add precursor patch to simply functions to only pass
ad7192_state
- add patch to replace custom attribute
- bindings patch: correct use of allOf and some minor changes to
the ad7194 example
- add ad7194 patch:
- use "ad7192 and similar"
- ad7194 no longer needs attribute group
- use callback function in chip_info to parse channels
- move struct ad7192_chip_info
- change position of parse functions
- drop clock bindings patch

v1 -> v2
- new commit with missing documentation for properties
- add constraint for channels in binding
- correct pattern for channels
- correct commit message by adding "()" to functions
- use in_range
- use preferred structure in Kconfig

Kind regards,

Alisa-Dariana Roman (4):
iio: adc: ad7192: Pass state directly
iio: adc: ad7192: Use standard attribute
dt-bindings: iio: adc: ad7192: Add AD7194 support
iio: adc: ad7192: Add AD7194 support

.../bindings/iio/adc/adi,ad7192.yaml | 75 ++++++
drivers/iio/adc/Kconfig | 11 +-
drivers/iio/adc/ad7192.c | 218 ++++++++++++++----
3 files changed, 250 insertions(+), 54 deletions(-)

--
2.34.1



2024-02-29 00:00:22

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v4 0/4] iio: adc: ad7192: Add support for AD7194

On Wed, Feb 28, 2024 at 02:26:13PM +0200, Alisa-Dariana Roman wrote:
> From: romandariana <[email protected]>

> Alisa-Dariana Roman (4):

Please fix and align the following:
- email From line (submitter)
- SoB tag(s)

--
With Best Regards,
Andy Shevchenko