2024-03-01 10:40:27

by Théo Lebrun

Subject: [PATCH] gpio: nomadik: fix Kconfig dependencies inbetween pinctrl & GPIO

PINCTRL_NOMADIK cannot select GPIO_NOMADIK without first selecting
GPIOLIB on which GPIO_NOMADIK depends. GPIO_NOMADIK depends on OF_GPIO,
it is a direct dependency.

Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Théo Lebrun <[email protected]>
---
Test robot usefully reported four related issues; see Closes
trailers for links. Here is a proposed fix. It applies on
top of ib-nomadik-gpio [0].

I'm fine with squashing if you prefer keeping the tree
clean of such commits. Unsure if that is what you usually do.

Have a nice day,
Théo

[0]: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=ib-nomadik-gpio
---
drivers/gpio/Kconfig | 2 +-
drivers/pinctrl/nomadik/Kconfig | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index fe6112abb73a..f633be517654 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -481,7 +481,7 @@ config GPIO_MXS
config GPIO_NOMADIK
bool "Nomadik GPIO driver"
depends on ARCH_U8500 || ARCH_NOMADIK || MACH_EYEQ5 || COMPILE_TEST
- select OF_GPIO
+ depends on OF_GPIO
select GPIOLIB_IRQCHIP
help
Say yes here to support the Nomadik SoC GPIO block. This block is also
diff --git a/drivers/pinctrl/nomadik/Kconfig b/drivers/pinctrl/nomadik/Kconfig
index 59d0d885651c..aafecf348670 100644
--- a/drivers/pinctrl/nomadik/Kconfig
+++ b/drivers/pinctrl/nomadik/Kconfig
@@ -25,6 +25,7 @@ config PINCTRL_NOMADIK
depends on OF
select PINMUX
select PINCONF
+ select GPIOLIB
select GPIO_NOMADIK

config PINCTRL_STN8815

---
base-commit: 6ad679cfaeea9291e9dce3247e34656080fc1d29
change-id: 20240301-mbly-gpio-kconfig-fix-e93b03052f88

Best regards,
--
Théo Lebrun <[email protected]>

2024-03-01 14:40:10

by Linus Walleij

Subject: Re: [PATCH] gpio: nomadik: fix Kconfig dependencies inbetween pinctrl & GPIO

On Fri, Mar 1, 2024 at 11:39 AM Théo Lebrun <[email protected]> wrote:

> PINCTRL_NOMADIK cannot select GPIO_NOMADIK without first selecting
> GPIOLIB on which GPIO_NOMADIK depends. GPIO_NOMADIK depends on OF_GPIO,
> it is a direct dependency.
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Théo Lebrun <[email protected]>
> ---
> Test robot usefully reported four related issues; see Closes
> trailers for links. Here is a proposed fix. It applies on
> top of ib-nomadik-gpio [0].

Quick work!

I applied this patch and pushed the branch again!

Yours,
Linus Walleij