Those two patches update the thermal device by converting the deprecated
txt documentation file to DT schema, and adding a required property in
the device tree where it is needed.
Signed-off-by: Raphael Gallais-Pou <[email protected]>
---
Changes in v2:
- [1/2] Change commit log to use imperative
- [1/2] Drop description
- [1/2] Drop 'clocks' description
- [1/2] Add 'reg' property
- [1/2] Add '#thermal-sensor-cells'
- [1/2] Make node name generic in example
- [1/2] Fix YAML style
---
Raphael Gallais-Pou (2):
dt-bindings: thermal: convert st,stih407-thermal to DT schema
ARM: dts: st: add thermal property on stih410.dtsi and stih418.dtsi
.../bindings/thermal/st,stih407-thermal.yaml | 56 ++++++++++++++++++++++
.../devicetree/bindings/thermal/st-thermal.txt | 32 -------------
arch/arm/boot/dts/st/stih410.dtsi | 1 +
arch/arm/boot/dts/st/stih418.dtsi | 1 +
4 files changed, 58 insertions(+), 32 deletions(-)
---
base-commit: b6d69282db550689ab5980e06eedd23b64584a73
change-id: 20240225-thermal-8cd0ba7f452b
Best regards,
--
Raphael Gallais-Pou <[email protected]>
'st,passive_colling_temp' does not appear in the device-tree, and 'reg'
is missing in the device description.
Convert st,stih407-thermal binding to DT schema format in order to clean
unused 'st,passive_cooling_temp' and add missing 'reg' property.
Signed-off-by: Raphael Gallais-Pou <[email protected]>
---
Changes in v2:
- Change commit log to use imperative
- Drop description
- Drop 'clocks' description
- Add 'reg' property
- Add '#thermal-sensor-cells'
- Make node name generic in example
- Fix YAML style
---
.../bindings/thermal/st,stih407-thermal.yaml | 56 ++++++++++++++++++++++
.../devicetree/bindings/thermal/st-thermal.txt | 32 -------------
2 files changed, 56 insertions(+), 32 deletions(-)
diff --git a/Documentation/devicetree/bindings/thermal/st,stih407-thermal.yaml b/Documentation/devicetree/bindings/thermal/st,stih407-thermal.yaml
new file mode 100644
index 000000000000..68d7dd8b892f
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/st,stih407-thermal.yaml
@@ -0,0 +1,56 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/thermal/st,stih407-thermal.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: STMicroelectronics STi digital thermal sensor (DTS)
+
+maintainers:
+ - Patrice Chotard <[email protected]>
+ - Lee Jones <[email protected]>
+
+allOf:
+ - $ref: thermal-sensor.yaml
+
+properties:
+ compatible:
+ const: st,stih407-thermal
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ clock-names:
+ items:
+ - const: thermal
+
+ interrupts:
+ description:
+ For thermal sensors for which no interrupt has been defined, a polling
+ delay of 1000ms will be used to read the temperature from device.
+
+ '#thermal-sensor-cells': true
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-names
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ temperature-sensor@91a0000 {
+ compatible = "st,stih407-thermal";
+ reg = <0x91a0000 0x28>;
+ clock-names = "thermal";
+ clocks = <&CLK_SYSIN>;
+ interrupts = <GIC_SPI 205 IRQ_TYPE_EDGE_RISING>;
+ #thermal-sensor-cells = <0>;
+ };
+...
diff --git a/Documentation/devicetree/bindings/thermal/st-thermal.txt b/Documentation/devicetree/bindings/thermal/st-thermal.txt
deleted file mode 100644
index a2f939137e35..000000000000
--- a/Documentation/devicetree/bindings/thermal/st-thermal.txt
+++ /dev/null
@@ -1,32 +0,0 @@
-Binding for Thermal Sensor driver for STMicroelectronics STi series of SoCs.
-
-Required parameters:
--------------------
-
-compatible : Should be "st,stih407-thermal"
-
-clock-names : Should be "thermal".
- See: Documentation/devicetree/bindings/resource-names.txt
-clocks : Phandle of the clock used by the thermal sensor.
- See: Documentation/devicetree/bindings/clock/clock-bindings.txt
-
-Optional parameters:
--------------------
-
-reg : For non-sysconf based sensors, this should be the physical base
- address and length of the sensor's registers.
-interrupts : Standard way to define interrupt number.
- NB: For thermal sensor's for which no interrupt has been
- defined, a polling delay of 1000ms will be used to read the
- temperature from device.
-
-Example:
-
- temp0@91a0000 {
- compatible = "st,stih407-thermal";
- reg = <0x91a0000 0x28>;
- clock-names = "thermal";
- clocks = <&CLK_SYSIN>;
- interrupts = <GIC_SPI 205 IRQ_TYPE_EDGE_RISING>;
- st,passive_cooling_temp = <110>;
- };
--
2.43.2
"#thermal-sensor-cells" is required and missing in thermal nodes.
Add it.
Signed-off-by: Raphael Gallais-Pou <[email protected]>
---
arch/arm/boot/dts/st/stih410.dtsi | 1 +
arch/arm/boot/dts/st/stih418.dtsi | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/st/stih410.dtsi b/arch/arm/boot/dts/st/stih410.dtsi
index 29e95e9d3229..a69231854f78 100644
--- a/arch/arm/boot/dts/st/stih410.dtsi
+++ b/arch/arm/boot/dts/st/stih410.dtsi
@@ -270,6 +270,7 @@ thermal@91a0000 {
clock-names = "thermal";
clocks = <&clk_sysin>;
interrupts = <GIC_SPI 205 IRQ_TYPE_EDGE_RISING>;
+ #thermal-sensor-cells = <0>;
};
cec@94a087c {
diff --git a/arch/arm/boot/dts/st/stih418.dtsi b/arch/arm/boot/dts/st/stih418.dtsi
index b35b9b7a7ccc..0f0db988a907 100644
--- a/arch/arm/boot/dts/st/stih418.dtsi
+++ b/arch/arm/boot/dts/st/stih418.dtsi
@@ -113,6 +113,7 @@ thermal@91a0000 {
clock-names = "thermal";
clocks = <&clk_sysin>;
interrupts = <GIC_SPI 205 IRQ_TYPE_EDGE_RISING>;
+ #thermal-sensor-cells = <0>;
};
};
};
--
2.43.2
On Fri, Mar 01, 2024 at 06:47:28PM +0100, Raphael Gallais-Pou wrote:
> 'st,passive_colling_temp' does not appear in the device-tree, and 'reg'
> is missing in the device description.
>
> Convert st,stih407-thermal binding to DT schema format in order to clean
> unused 'st,passive_cooling_temp' and add missing 'reg' property.
>
> Signed-off-by: Raphael Gallais-Pou <[email protected]>
> ---
> Changes in v2:
> - Change commit log to use imperative
> - Drop description
> - Drop 'clocks' description
> - Add 'reg' property
> - Add '#thermal-sensor-cells'
> - Make node name generic in example
> - Fix YAML style
> ---
> .../bindings/thermal/st,stih407-thermal.yaml | 56 ++++++++++++++++++++++
> .../devicetree/bindings/thermal/st-thermal.txt | 32 -------------
> 2 files changed, 56 insertions(+), 32 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/st,stih407-thermal.yaml b/Documentation/devicetree/bindings/thermal/st,stih407-thermal.yaml
> new file mode 100644
> index 000000000000..68d7dd8b892f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/st,stih407-thermal.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/st,stih407-thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: STMicroelectronics STi digital thermal sensor (DTS)
> +
> +maintainers:
> + - Patrice Chotard <[email protected]>
> + - Lee Jones <[email protected]>
> +
> +allOf:
> + - $ref: thermal-sensor.yaml
> +
> +properties:
> + compatible:
> + const: st,stih407-thermal
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: thermal
> +
> + interrupts:
> + description:
> + For thermal sensors for which no interrupt has been defined, a polling
> + delay of 1000ms will be used to read the temperature from device.
maxItems: 1
> +
> + '#thermal-sensor-cells': true
const: 1
Also, not in the original binding, so please state in the commit msg
why you are adding it.
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + temperature-sensor@91a0000 {
> + compatible = "st,stih407-thermal";
> + reg = <0x91a0000 0x28>;
> + clock-names = "thermal";
> + clocks = <&CLK_SYSIN>;
> + interrupts = <GIC_SPI 205 IRQ_TYPE_EDGE_RISING>;
> + #thermal-sensor-cells = <0>;
> + };
> +...
Le 04/03/2024 à 19:40, Rob Herring a écrit :
> On Fri, Mar 01, 2024 at 06:47:28PM +0100, Raphael Gallais-Pou wrote:
>> 'st,passive_colling_temp' does not appear in the device-tree, and 'reg'
>> is missing in the device description.
>>
>> Convert st,stih407-thermal binding to DT schema format in order to clean
>> unused 'st,passive_cooling_temp' and add missing 'reg' property.
>>
>> Signed-off-by: Raphael Gallais-Pou <[email protected]>
Hi Rob,
..
>> + interrupts:
>> + description:
>> + For thermal sensors for which no interrupt has been defined, a polling
>> + delay of 1000ms will be used to read the temperature from device.
>
> maxItems: 1
Ack.
>
>> +
>> + '#thermal-sensor-cells': true
>
> const: 1
>
> Also, not in the original binding, so please state in the commit msg
> why you are adding it.
I have mixed feeling regarding the value. Wouldn't this better be
'const: 0' ?
In the thermal-sensor binding it is specified that it should be 0 for
single sensor nodes, which is our case.
>
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - clocks
>> + - clock-names
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> + temperature-sensor@91a0000 {
>> + compatible = "st,stih407-thermal";
>> + reg = <0x91a0000 0x28>;
>> + clock-names = "thermal";
>> + clocks = <&CLK_SYSIN>;
>> + interrupts = <GIC_SPI 205 IRQ_TYPE_EDGE_RISING>;
>> + #thermal-sensor-cells = <0>;
If I misunderstand something and the value must be 1 then I will also
change the value here and in the dt patches of the serie.
Regards,
Raphaël
>> + };
>> +...
Hi Rob,
It's been a few weeks.
Gentle ping :)
Regards,
Raphaël
Le 06/03/2024 à 08:53, Raphaël Gallais-Pou a écrit :
>
>
> Le 04/03/2024 à 19:40, Rob Herring a écrit :
>> On Fri, Mar 01, 2024 at 06:47:28PM +0100, Raphael Gallais-Pou wrote:
>>> 'st,passive_colling_temp' does not appear in the device-tree, and 'reg'
>>> is missing in the device description.
>>>
>>> Convert st,stih407-thermal binding to DT schema format in order to clean
>>> unused 'st,passive_cooling_temp' and add missing 'reg' property.
>>>
>>> Signed-off-by: Raphael Gallais-Pou <[email protected]>
>
>
> Hi Rob,
>
> ...
>
>>> + interrupts:
>>> + description:
>>> + For thermal sensors for which no interrupt has been defined, a
>>> polling
>>> + delay of 1000ms will be used to read the temperature from device.
>>
>> maxItems: 1
>
> Ack.
>>
>>> +
>>> + '#thermal-sensor-cells': true
>>
>> const: 1
>>
>> Also, not in the original binding, so please state in the commit msg
>> why you are adding it.
>
> I have mixed feeling regarding the value. Wouldn't this better be
> 'const: 0' ?
>
> In the thermal-sensor binding it is specified that it should be 0 for
> single sensor nodes, which is our case.
>
>>
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>>> + - clocks
>>> + - clock-names
>>> +
>>> +unevaluatedProperties: false
>>> +
>>> +examples:
>>> + - |
>>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> + temperature-sensor@91a0000 {
>>> + compatible = "st,stih407-thermal";
>>> + reg = <0x91a0000 0x28>;
>>> + clock-names = "thermal";
>>> + clocks = <&CLK_SYSIN>;
>>> + interrupts = <GIC_SPI 205 IRQ_TYPE_EDGE_RISING>;
>>> + #thermal-sensor-cells = <0>;
>
> If I misunderstand something and the value must be 1 then I will also
> change the value here and in the dt patches of the serie.
>
> Regards,
> Raphaël
>>> + };
>>> +...
On 19/03/2024 20:32, Raphaël Gallais-Pou wrote:
> Hi Rob,
>
> It's been a few weeks.
Just choose the value which is correct. If you have just one sensor,
then cells=0, like you suggested.
Best regards,
Krzysztof