2024-02-29 18:37:53

by Conor Dooley

Subject: [RESEND] dt-bindings: leds: pwm-multicolour: re-allow active-low

From: Conor Dooley <[email protected]>

active-low was lifted to the common schema for leds, but it went
unnoticed that the leds-multicolour binding had "additionalProperties:
false" where the other users had "unevaluatedProperties: false", thereby
disallowing active-low for multicolour leds. Explicitly permit it again.

Fixes: c94d1783136e ("dt-bindings: net: phy: Make LED active-low property common")
Acked-by: Rob Herring <[email protected]>
Signed-off-by: Conor Dooley <[email protected]>
---

This needs to go via netdev as the commit it fixes (and is based on)
is there

CC: Pavel Machek <[email protected]>
CC: Lee Jones <[email protected]>
CC: Rob Herring <[email protected]>
CC: Krzysztof Kozlowski <[email protected]>
CC: Conor Dooley <[email protected]>
CC: Sven Schwermer <[email protected]>
CC: Christian Marangi <[email protected]>
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: "David S. Miller" <[email protected]>
CC: Eric Dumazet <[email protected]>
CC: Jakub Kicinski <[email protected]>
CC: Paolo Abeni <[email protected]>
CC: [email protected]
---
Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
index 5edfbe347341..a31a202afe5c 100644
--- a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
@@ -41,6 +41,8 @@ properties:

pwm-names: true

+ active-low: true
+
color: true

required:
--
2.43.0

2024-03-01 07:59:53

by Lee Jones

Subject: Re: [RESEND] dt-bindings: leds: pwm-multicolour: re-allow active-low

On Thu, 29 Feb 2024, Conor Dooley wrote:

> From: Conor Dooley <[email protected]>
>
> active-low was lifted to the common schema for leds, but it went
> unnoticed that the leds-multicolour binding had "additionalProperties:
> false" where the other users had "unevaluatedProperties: false", thereby
> disallowing active-low for multicolour leds. Explicitly permit it again.
>
> Fixes: c94d1783136e ("dt-bindings: net: phy: Make LED active-low property common")
> Acked-by: Rob Herring <[email protected]>
> Signed-off-by: Conor Dooley <[email protected]>
> ---
>
> This needs to go via netdev as the commit it fixes (and is based on)
> is there
>
> CC: Pavel Machek <[email protected]>
> CC: Lee Jones <[email protected]>
> CC: Rob Herring <[email protected]>
> CC: Krzysztof Kozlowski <[email protected]>
> CC: Conor Dooley <[email protected]>
> CC: Sven Schwermer <[email protected]>
> CC: Christian Marangi <[email protected]>
> CC: [email protected]
> CC: [email protected]
> CC: [email protected]
> CC: "David S. Miller" <[email protected]>
> CC: Eric Dumazet <[email protected]>
> CC: Jakub Kicinski <[email protected]>
> CC: Paolo Abeni <[email protected]>
> CC: [email protected]
> ---
> Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml | 2 ++
> 1 file changed, 2 insertions(+)

Please take this via netdev.

Acked-by: Lee Jones <[email protected]>

> diff --git a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> index 5edfbe347341..a31a202afe5c 100644
> --- a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> @@ -41,6 +41,8 @@ properties:
>
> pwm-names: true
>
> + active-low: true
> +
> color: true
>
> required:
> --
> 2.43.0
>
>

--
Lee Jones [李琼斯]

2024-03-04 09:07:50

by patchwork-bot+netdevbpf

Subject: Re: [RESEND] dt-bindings: leds: pwm-multicolour: re-allow active-low

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <[email protected]>:

On Thu, 29 Feb 2024 18:24:00 +0000 you wrote:
> From: Conor Dooley <[email protected]>
>
> active-low was lifted to the common schema for leds, but it went
> unnoticed that the leds-multicolour binding had "additionalProperties:
> false" where the other users had "unevaluatedProperties: false", thereby
> disallowing active-low for multicolour leds. Explicitly permit it again.
>
> [...]

Here is the summary with links:
- [RESEND] dt-bindings: leds: pwm-multicolour: re-allow active-low
https://git.kernel.org/netdev/net-next/c/df620d7fabe9

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html