2024-03-01 08:41:06

by Yang Li

[permalink] [raw]
Subject: [PATCH -next] powercap: dtpm: Fix kernel-doc for dtpm_create_hierarchy function

The existing comment block above the dtpm_create_hierarchy function
does not conform to the kernel-doc standard. This patch fixes the
documentation to match the expected kernel-doc format, which includes
a structured documentation header with param and return value.

Signed-off-by: Yang Li <[email protected]>
---
drivers/powercap/dtpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/powercap/dtpm.c b/drivers/powercap/dtpm.c
index ce920f17f45f..f390665743c4 100644
--- a/drivers/powercap/dtpm.c
+++ b/drivers/powercap/dtpm.c
@@ -522,7 +522,7 @@ static int dtpm_for_each_child(const struct dtpm_node *hierarchy,

/**
* dtpm_create_hierarchy - Create the dtpm hierarchy
- * @hierarchy: An array of struct dtpm_node describing the hierarchy
+ * @dtpm_match_table: Pointer to the array of device ID structures
*
* The function is called by the platform specific code with the
* description of the different node in the hierarchy. It creates the
--
2.20.1.7.g153144c



2024-03-01 19:25:18

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH -next] powercap: dtpm: Fix kernel-doc for dtpm_create_hierarchy function



On 3/1/24 00:18, Yang Li wrote:
> The existing comment block above the dtpm_create_hierarchy function
> does not conform to the kernel-doc standard. This patch fixes the
> documentation to match the expected kernel-doc format, which includes
> a structured documentation header with param and return value.
>
> Signed-off-by: Yang Li <[email protected]>

Reviewed-by: Randy Dunlap <[email protected]>
Thanks.

> ---
> drivers/powercap/dtpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/powercap/dtpm.c b/drivers/powercap/dtpm.c
> index ce920f17f45f..f390665743c4 100644
> --- a/drivers/powercap/dtpm.c
> +++ b/drivers/powercap/dtpm.c
> @@ -522,7 +522,7 @@ static int dtpm_for_each_child(const struct dtpm_node *hierarchy,
>
> /**
> * dtpm_create_hierarchy - Create the dtpm hierarchy
> - * @hierarchy: An array of struct dtpm_node describing the hierarchy
> + * @dtpm_match_table: Pointer to the array of device ID structures
> *
> * The function is called by the platform specific code with the
> * description of the different node in the hierarchy. It creates the

--
#Randy

2024-03-01 20:51:44

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH -next] powercap: dtpm: Fix kernel-doc for dtpm_create_hierarchy function

On Fri, Mar 1, 2024 at 8:24 PM Randy Dunlap <[email protected]> wrote:
>
>
>
> On 3/1/24 00:18, Yang Li wrote:
> > The existing comment block above the dtpm_create_hierarchy function
> > does not conform to the kernel-doc standard. This patch fixes the
> > documentation to match the expected kernel-doc format, which includes
> > a structured documentation header with param and return value.
> >
> > Signed-off-by: Yang Li <[email protected]>
>
> Reviewed-by: Randy Dunlap <[email protected]>

Applied, thanks!