2024-03-01 08:53:53

by Alexander Stein

Subject: [PATCH v3 1/2] media: dt-bindings: sony,imx290: Allow props from video-interface-devices

Allow properties from video-interface-devices. This aligns the bindings
to sony,imx415.yaml. Changes inspired by commit e2e73ed46c395 ("media:
dt-bindings: sony,imx415: Allow props from video-interface-devices")

Signed-off-by: Alexander Stein <[email protected]>
Reviewed-by: Laurent Pinchart <[email protected]>
Acked-by: Conor Dooley <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---
Changes in v3:
* Collected R-b & A-b

Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml
index a531badc16c98..bf05ca48601ab 100644
--- a/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml
@@ -23,6 +23,9 @@ description: |-
is treated the same as this as it was the original compatible string.
imx290llr is the mono version of the sensor.

+allOf:
+ - $ref: /schemas/media/video-interface-devices.yaml#
+
properties:
compatible:
oneOf:
@@ -101,7 +104,7 @@ required:
- vdddo-supply
- port

-additionalProperties: false
+unevaluatedProperties: false

examples:
- |
--
2.34.1

2024-03-01 08:54:19

by Alexander Stein

Subject: [PATCH v3 2/2] media: dt-bindings: i2c: use absolute path to other schema

Absolute path to other DT schema is preferred over relative one.

Signed-off-by: Alexander Stein <[email protected]>
---
Changes in v3:
* Squashed patches 2-5 from v2 into a single one

.../devicetree/bindings/media/i2c/galaxycore,gc0308.yaml | 2 +-
.../devicetree/bindings/media/i2c/galaxycore,gc2145.yaml | 2 +-
Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml | 2 +-
Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc0308.yaml b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc0308.yaml
index f81e7daed67b6..2bf1a81feaf47 100644
--- a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc0308.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc0308.yaml
@@ -15,7 +15,7 @@ description: |
They include an ISP capable of auto exposure and auto white balance.

allOf:
- - $ref: ../video-interface-devices.yaml#
+ - $ref: /schemas/media/video-interface-devices.yaml#

properties:
compatible:
diff --git a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
index 1726ecca4c77e..9eac588de0bc2 100644
--- a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
@@ -19,7 +19,7 @@ description:
either through a parallel interface or through MIPI CSI-2.

allOf:
- - $ref: ../video-interface-devices.yaml#
+ - $ref: /schemas/media/video-interface-devices.yaml#

properties:
compatible:
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
index 60903da84e1f3..0162eec8ca993 100644
--- a/Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
@@ -16,7 +16,7 @@ description: |
maximum throughput of 1.2Gbps/lane.

allOf:
- - $ref: ../video-interface-devices.yaml#
+ - $ref: /schemas/media/video-interface-devices.yaml#

properties:
compatible:
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
index 9a00dab2e8a3f..34962c5c70065 100644
--- a/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
@@ -18,7 +18,7 @@ description: |-
available via CSI-2 serial data output (two or four lanes).

allOf:
- - $ref: ../video-interface-devices.yaml#
+ - $ref: /schemas/media/video-interface-devices.yaml#

properties:
compatible:
--
2.34.1

2024-03-01 08:57:59

by Laurent Pinchart

Subject: Re: [PATCH v3 2/2] media: dt-bindings: i2c: use absolute path to other schema

Hi Alexander,

Thank you for the patch.

On Fri, Mar 01, 2024 at 09:40:08AM +0100, Alexander Stein wrote:
> Absolute path to other DT schema is preferred over relative one.
>
> Signed-off-by: Alexander Stein <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> Changes in v3:
> * Squashed patches 2-5 from v2 into a single one
>
> .../devicetree/bindings/media/i2c/galaxycore,gc0308.yaml | 2 +-
> .../devicetree/bindings/media/i2c/galaxycore,gc2145.yaml | 2 +-
> Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml | 2 +-
> Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc0308.yaml b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc0308.yaml
> index f81e7daed67b6..2bf1a81feaf47 100644
> --- a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc0308.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc0308.yaml
> @@ -15,7 +15,7 @@ description: |
> They include an ISP capable of auto exposure and auto white balance.
>
> allOf:
> - - $ref: ../video-interface-devices.yaml#
> + - $ref: /schemas/media/video-interface-devices.yaml#
>
> properties:
> compatible:
> diff --git a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
> index 1726ecca4c77e..9eac588de0bc2 100644
> --- a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
> @@ -19,7 +19,7 @@ description:
> either through a parallel interface or through MIPI CSI-2.
>
> allOf:
> - - $ref: ../video-interface-devices.yaml#
> + - $ref: /schemas/media/video-interface-devices.yaml#
>
> properties:
> compatible:
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
> index 60903da84e1f3..0162eec8ca993 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
> @@ -16,7 +16,7 @@ description: |
> maximum throughput of 1.2Gbps/lane.
>
> allOf:
> - - $ref: ../video-interface-devices.yaml#
> + - $ref: /schemas/media/video-interface-devices.yaml#
>
> properties:
> compatible:
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
> index 9a00dab2e8a3f..34962c5c70065 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
> @@ -18,7 +18,7 @@ description: |-
> available via CSI-2 serial data output (two or four lanes).
>
> allOf:
> - - $ref: ../video-interface-devices.yaml#
> + - $ref: /schemas/media/video-interface-devices.yaml#
>
> properties:
> compatible:

--
Regards,

Laurent Pinchart