2024-03-04 02:24:41

by Jiapeng Chong

Subject: [PATCH] xfs: Remove unused function is_rt_data_fork

The function are defined in the rmap_repair.c file, but not called
elsewhere, so delete the unused function.

fs/xfs/scrub/rmap_repair.c:436:1: warning: unused function 'is_rt_data_fork'.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8425
Signed-off-by: Jiapeng Chong <[email protected]>
---
fs/xfs/scrub/rmap_repair.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/fs/xfs/scrub/rmap_repair.c b/fs/xfs/scrub/rmap_repair.c
index e8e07b683eab..7e73ddfb3d44 100644
--- a/fs/xfs/scrub/rmap_repair.c
+++ b/fs/xfs/scrub/rmap_repair.c
@@ -432,14 +432,6 @@ xrep_rmap_scan_iroot_btree(
return error;
}

-static inline bool
-is_rt_data_fork(
- struct xfs_inode *ip,
- int whichfork)
-{
- return XFS_IS_REALTIME_INODE(ip) && whichfork == XFS_DATA_FORK;
-}
-
/*
* Iterate the block mapping btree to collect rmap records for anything in this
* fork that matches the AG. Sets @mappings_done to true if we've scanned the
--
2.20.1.7.g153144c

2024-03-04 02:44:55

by Darrick J. Wong

Subject: Re: [PATCH] xfs: Remove unused function is_rt_data_fork

On Mon, Mar 04, 2024 at 10:24:08AM +0800, Jiapeng Chong wrote:
> The function are defined in the rmap_repair.c file, but not called
> elsewhere, so delete the unused function.
>
> fs/xfs/scrub/rmap_repair.c:436:1: warning: unused function 'is_rt_data_fork'.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8425
> Signed-off-by: Jiapeng Chong <[email protected]>

Oh hey, that really /is/ unused, even in djwong-wtf. Good catch!

Reviewed-by: Darrick J. Wong <[email protected]>

--D

> ---
> fs/xfs/scrub/rmap_repair.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/fs/xfs/scrub/rmap_repair.c b/fs/xfs/scrub/rmap_repair.c
> index e8e07b683eab..7e73ddfb3d44 100644
> --- a/fs/xfs/scrub/rmap_repair.c
> +++ b/fs/xfs/scrub/rmap_repair.c
> @@ -432,14 +432,6 @@ xrep_rmap_scan_iroot_btree(
> return error;
> }
>
> -static inline bool
> -is_rt_data_fork(
> - struct xfs_inode *ip,
> - int whichfork)
> -{
> - return XFS_IS_REALTIME_INODE(ip) && whichfork == XFS_DATA_FORK;
> -}
> -
> /*
> * Iterate the block mapping btree to collect rmap records for anything in this
> * fork that matches the AG. Sets @mappings_done to true if we've scanned the
> --
> 2.20.1.7.g153144c
>
>