Hello everyone,
This patch series add support for the Crystal Clear Technology
CMT430B19N00 4.3" 480x272 TFT-LCD panel.
It also adds Crystal Clear Technology to vendor-prefixes.yaml.
Please note that unfortunately there is no public datasheet available
for this panel.
Changes in v2:
- add link to the Crystal Clear Technology website in commit message, as
suggested by Conor Dooley and Neil Armstrong.
Regards,
Jérémie
Jérémie Dautheribes (3):
dt-bindings: Add Crystal Clear Technology vendor prefix
dt-bindings: display: simple: add support for Crystal Clear
CMT430B19N00
drm/panel: simple: add CMT430B19N00 LCD panel support
.../bindings/display/panel/panel-simple.yaml | 2 ++
.../devicetree/bindings/vendor-prefixes.yaml | 2 ++
drivers/gpu/drm/panel/panel-simple.c | 29 +++++++++++++++++++
3 files changed, 33 insertions(+)
--
2.34.1
---
- Link to v1: https://lore.kernel.org/all/[email protected]/
Add support for Crystal Clear Technology CMT430B19N00 4.3" 480x272
TFT-LCD panel.
Signed-off-by: Jérémie Dautheribes <[email protected]>
---
drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 20e3df1c59d4..b940220f56e2 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1457,6 +1457,32 @@ static const struct panel_desc boe_hv070wsa = {
.connector_type = DRM_MODE_CONNECTOR_LVDS,
};
+static const struct drm_display_mode cct_cmt430b19n00_mode = {
+ .clock = 9000,
+ .hdisplay = 480,
+ .hsync_start = 480 + 43,
+ .hsync_end = 480 + 43 + 8,
+ .htotal = 480 + 43 + 8 + 4,
+ .vdisplay = 272,
+ .vsync_start = 272 + 12,
+ .vsync_end = 272 + 12 + 8,
+ .vtotal = 272 + 12 + 8 + 4,
+ .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
+static const struct panel_desc cct_cmt430b19n00 = {
+ .modes = &cct_cmt430b19n00_mode,
+ .num_modes = 1,
+ .bpc = 8,
+ .size = {
+ .width = 95,
+ .height = 53,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE,
+ .connector_type = DRM_MODE_CONNECTOR_DPI,
+};
+
static const struct drm_display_mode cdtech_s043wq26h_ct7_mode = {
.clock = 9000,
.hdisplay = 480,
@@ -4402,6 +4428,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "boe,hv070wsa-100",
.data = &boe_hv070wsa
+ }, {
+ .compatible = "cct,cmt430b19n00",
+ .data = &cct_cmt430b19n00,
}, {
.compatible = "cdtech,s043wq26h-ct7",
.data = &cdtech_s043wq26h_ct7,
--
2.34.1
On Mon, Mar 04, 2024 at 05:04:51PM +0100, J?r?mie Dautheribes wrote:
> Hello everyone,
>
> This patch series add support for the Crystal Clear Technology
> CMT430B19N00 4.3" 480x272 TFT-LCD panel.
> It also adds Crystal Clear Technology to vendor-prefixes.yaml.
>
> Please note that unfortunately there is no public datasheet available
> for this panel.
>
> Changes in v2:
> - add link to the Crystal Clear Technology website in commit message, as
> suggested by Conor Dooley and Neil Armstrong.
You forgot however to add the acks that I gave you for the two
dt-binding patches.
On Mon, Mar 04, 2024 at 07:29:04PM +0000, Conor Dooley wrote:
> On Mon, Mar 04, 2024 at 05:04:51PM +0100, J?r?mie Dautheribes wrote:
> > Hello everyone,
> >
> > This patch series add support for the Crystal Clear Technology
> > CMT430B19N00 4.3" 480x272 TFT-LCD panel.
> > It also adds Crystal Clear Technology to vendor-prefixes.yaml.
> >
> > Please note that unfortunately there is no public datasheet available
> > for this panel.
> >
> > Changes in v2:
> > - add link to the Crystal Clear Technology website in commit message, as
> > suggested by Conor Dooley and Neil Armstrong.
>
> You forgot however to add the acks that I gave you for the two
> dt-binding patches.
I was wondering why my scripts said this was already reviewed with that
missing. Turns out b4 will now check prior versions and add the tags as
long as the patch-id matches. Neat, but the submitter really has to
grasp how that all works (knowing if the patch-id changed) as well as
the maintainer has to use b4, so we can't really rely on it.
Here's b4 debug log:
new message: 20240223-subtotal-aground-268d135adeff@spud
Running git --no-pager patch-id --stable
found matching patch-id for Re: [PATCH 2/3] dt-bindings: display: simple: add support for Crystal Clear CMT430B19N00
new message: 20240229-woven-lively-1d90687b2d03@spud
skipping reply without trailers: 20240229-woven-lively-1d90687b2d03@spud
new message: [email protected]
skipping non-reply: [email protected]
Analyzing follow-up: Re: [PATCH v2 0/3] panel-simple: add support for Crystal Clear CMT430B19N00 ([email protected])
no trailers found, skipping
Analyzing follow-up: Re: [PATCH v2 3/3] drm/panel: simple: add CMT430B19N00 LCD panel support ([email protected])
no trailers found, skipping
adding "Acked-by: Conor Dooley <[email protected]>" from trailer_map to: [PATCH v2 1/3] dt-bindings: Add Crystal C
lear Technology vendor prefix
adding "Link: http://www.cct.com.my/" from trailer_map to: [PATCH v2 1/3] dt-bindings: Add Crystal Clear Technology vendor
prefix
adding "Acked-by: Conor Dooley <[email protected]>" from trailer_map to: [PATCH v2 2/3] dt-bindings: display: simp
le: add support for Crystal Clear CMT430B19N00
adding "Reviewed-by: Neil Armstrong <[email protected]>" from trailer_map to: [PATCH v2 3/3] drm/panel: simple: add
CMT430B19N00 LCD panel support
adding "Reviewed-by: Jessica Zhang <[email protected]>" from trailer_map to: [PATCH v2 3/3] drm/panel: simple: add
CMT430B19N00 LCD panel support
Hi Conor,
On 04/03/2024 20:29, Conor Dooley wrote:
> On Mon, Mar 04, 2024 at 05:04:51PM +0100, Jérémie Dautheribes wrote:
>> Hello everyone,
>>
>> This patch series add support for the Crystal Clear Technology
>> CMT430B19N00 4.3" 480x272 TFT-LCD panel.
>> It also adds Crystal Clear Technology to vendor-prefixes.yaml.
>>
>> Please note that unfortunately there is no public datasheet available
>> for this panel.
>>
>> Changes in v2:
>> - add link to the Crystal Clear Technology website in commit message, as
>> suggested by Conor Dooley and Neil Armstrong.
>
> You forgot however to add the acks that I gave you for the two
> dt-binding patches.
Oops you are right, I'm sorry. Should I send a v3 containing these acks?
Best regards,
Jérémie
On Mon, Mar 04, 2024 at 03:24:51PM -0600, Rob Herring wrote:
> On Mon, Mar 04, 2024 at 07:29:04PM +0000, Conor Dooley wrote:
> > On Mon, Mar 04, 2024 at 05:04:51PM +0100, J?r?mie Dautheribes wrote:
> > > Hello everyone,
> > >
> > > This patch series add support for the Crystal Clear Technology
> > > CMT430B19N00 4.3" 480x272 TFT-LCD panel.
> > > It also adds Crystal Clear Technology to vendor-prefixes.yaml.
> > >
> > > Please note that unfortunately there is no public datasheet available
> > > for this panel.
> > >
> > > Changes in v2:
> > > - add link to the Crystal Clear Technology website in commit message, as
> > > suggested by Conor Dooley and Neil Armstrong.
> >
> > You forgot however to add the acks that I gave you for the two
> > dt-binding patches.
>
> I was wondering why my scripts said this was already reviewed with that
> missing. Turns out b4 will now check prior versions and add the tags as
> long as the patch-id matches. Neat, but the submitter really has to
> grasp how that all works (knowing if the patch-id changed) as well as
> the maintainer has to use b4, so we can't really rely on it.
>
> Here's b4 debug log:
>
> new message: 20240223-subtotal-aground-268d135adeff@spud
> Running git --no-pager patch-id --stable
> found matching patch-id for Re: [PATCH 2/3] dt-bindings: display: simple: add support for Crystal Clear CMT430B19N00
> new message: 20240229-woven-lively-1d90687b2d03@spud
> skipping reply without trailers: 20240229-woven-lively-1d90687b2d03@spud
> new message: [email protected]
> skipping non-reply: [email protected]
> Analyzing follow-up: Re: [PATCH v2 0/3] panel-simple: add support for Crystal Clear CMT430B19N00 ([email protected])
> no trailers found, skipping
> Analyzing follow-up: Re: [PATCH v2 3/3] drm/panel: simple: add CMT430B19N00 LCD panel support ([email protected])
> no trailers found, skipping
> adding "Acked-by: Conor Dooley <[email protected]>" from trailer_map to: [PATCH v2 1/3] dt-bindings: Add Crystal C
> lear Technology vendor prefix
> adding "Link: http://www.cct.com.my/" from trailer_map to: [PATCH v2 1/3] dt-bindings: Add Crystal Clear Technology vendor
> prefix
This is the other nice thing that b4 does, pick up "non review"
trailers too.
> adding "Acked-by: Conor Dooley <[email protected]>" from trailer_map to: [PATCH v2 2/3] dt-bindings: display: simp
> le: add support for Crystal Clear CMT430B19N00
> adding "Reviewed-by: Neil Armstrong <[email protected]>" from trailer_map to: [PATCH v2 3/3] drm/panel: simple: add
> CMT430B19N00 LCD panel support
> adding "Reviewed-by: Jessica Zhang <[email protected]>" from trailer_map to: [PATCH v2 3/3] drm/panel: simple: add
> CMT430B19N00 LCD panel support
On Tue, Mar 05, 2024 at 10:48:56AM +0100, J?r?mie Dautheribes wrote:
> Hi Conor,
>
> On 04/03/2024 20:29, Conor Dooley wrote:
> > On Mon, Mar 04, 2024 at 05:04:51PM +0100, J?r?mie Dautheribes wrote:
> > > Hello everyone,
> > >
> > > This patch series add support for the Crystal Clear Technology
> > > CMT430B19N00 4.3" 480x272 TFT-LCD panel.
> > > It also adds Crystal Clear Technology to vendor-prefixes.yaml.
> > >
> > > Please note that unfortunately there is no public datasheet available
> > > for this panel.
> > >
> > > Changes in v2:
> > > - add link to the Crystal Clear Technology website in commit message, as
> > > suggested by Conor Dooley and Neil Armstrong.
> >
> > You forgot however to add the acks that I gave you for the two
> > dt-binding patches.
>
>
> Oops you are right, I'm sorry. Should I send a v3 containing these acks?
I was going to just provide them here, I just wanted to make sure you
didn't intentionally drop them first. But in the interim you got some
from Krzysztof, making some from me redundant anyway :)
I wouldn't bother adding the forgotten acks or resending, I don't care
about my ack count :)