2024-03-05 16:01:05

by Krzysztof Kozlowski

Subject: [PATCH] riscv: dts: starfive: jh7100: fix root clock names

JH7100 clock controller driver depends on certain root clock names.

Reported-by: Geert Uytterhoeven <[email protected]>
Closes: https://lore.kernel.org/all/CAMuHMdWw0dteXO2jw4cwGvzKcL6vmnb96C=qgPgUqNDMtF6X0Q@mail.gmail.com/
Fixes: f03606470886 ("riscv: dts: starfive: replace underscores in node names")
Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Not tested on hardware
---
arch/riscv/boot/dts/starfive/jh7100.dtsi | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/riscv/boot/dts/starfive/jh7100.dtsi b/arch/riscv/boot/dts/starfive/jh7100.dtsi
index 90149e379c10..9a2e9583af88 100644
--- a/arch/riscv/boot/dts/starfive/jh7100.dtsi
+++ b/arch/riscv/boot/dts/starfive/jh7100.dtsi
@@ -116,6 +116,7 @@ cpu-crit {
osc_sys: osc-sys {
compatible = "fixed-clock";
#clock-cells = <0>;
+ clock-output-names = "osc_sys";
/* This value must be overridden by the board */
clock-frequency = <0>;
};
@@ -123,6 +124,7 @@ osc_sys: osc-sys {
osc_aud: osc-aud {
compatible = "fixed-clock";
#clock-cells = <0>;
+ clock-output-names = "osc_aud";
/* This value must be overridden by the board */
clock-frequency = <0>;
};
@@ -130,6 +132,7 @@ osc_aud: osc-aud {
gmac_rmii_ref: gmac-rmii-ref {
compatible = "fixed-clock";
#clock-cells = <0>;
+ clock-output-names = "gmac_rmii_ref";
/* Should be overridden by the board when needed */
clock-frequency = <0>;
};
@@ -137,6 +140,7 @@ gmac_rmii_ref: gmac-rmii-ref {
gmac_gr_mii_rxclk: gmac-gr-mii-rxclk {
compatible = "fixed-clock";
#clock-cells = <0>;
+ clock-output-names = "gmac_gr_mii_rxclk";
/* Should be overridden by the board when needed */
clock-frequency = <0>;
};
--
2.34.1

2024-03-05 16:11:25

by Geert Uytterhoeven

Subject: Re: [PATCH] riscv: dts: starfive: jh7100: fix root clock names

On Tue, Mar 5, 2024 at 5:00 PM Krzysztof Kozlowski
<[email protected]> wrote:
> JH7100 clock controller driver depends on certain root clock names.
>
> Reported-by: Geert Uytterhoeven <[email protected]>
> Closes: https://lore.kernel.org/all/CAMuHMdWw0dteXO2jw4cwGvzKcL6vmnb96C=qgPgUqNDMtF6X0Q@mail.gmail.com/
> Fixes: f03606470886 ("riscv: dts: starfive: replace underscores in node names")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Not tested on hardware

Tested-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2024-03-06 00:14:04

by Conor Dooley

Subject: Re: [PATCH] riscv: dts: starfive: jh7100: fix root clock names

From: Conor Dooley <[email protected]>

On Tue, 05 Mar 2024 17:00:46 +0100, Krzysztof Kozlowski wrote:
> JH7100 clock controller driver depends on certain root clock names.
>
>

Applied to riscv-dt-fixes, thanks!

[1/1] riscv: dts: starfive: jh7100: fix root clock names
https://git.kernel.org/conor/c/7921e231f85a

Thanks,
Conor.