2024-03-04 23:43:45

by David Heidelberg

Subject: [PATCH] dt-bindings: opp: drop maxItems from inner items

With recent changes within matrix dimensions calculation,
dropping maxItems: 1 provides a warning-free run.

Fixes warning such as:
arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dtb: opp-table: opp-200000000:opp-hz:0: [200000000, 0, 0, 150000000, 0, 0, 0, 0, 300000000] is too long

Fixes: 3cb16ad69bef ("dt-bindings: opp: accept array of frequencies")
Suggested-by: Rob Herring <[email protected]>
Signed-off-by: David Heidelberg <[email protected]>
---
follow-up of https://lore.kernel.org/lkml/[email protected]/T/

Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 --
1 file changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
index e2f8f7af3cf4..b1bb87c865ed 100644
--- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
+++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
@@ -57,8 +57,6 @@ patternProperties:
specific binding.
minItems: 1
maxItems: 32
- items:
- maxItems: 1

opp-microvolt:
description: |
--
2.43.0

2024-03-05 05:39:22

by Dhruva Gole

Subject: Re: [PATCH] dt-bindings: opp: drop maxItems from inner items

Hi,

On 05/03/24 05:13, David Heidelberg wrote:
> With recent changes within matrix dimensions calculation,
> dropping maxItems: 1 provides a warning-free run.
>
> Fixes warning such as:
> arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dtb: opp-table: opp-200000000:opp-hz:0: [200000000, 0, 0, 150000000, 0, 0, 0, 0, 300000000] is too long
>
> Fixes: 3cb16ad69bef ("dt-bindings: opp: accept array of frequencies")
> Suggested-by: Rob Herring <[email protected]>
> Signed-off-by: David Heidelberg <[email protected]>
> ---
> follow-up of https://lore.kernel.org/lkml/[email protected]/T/
>
> Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> index e2f8f7af3cf4..b1bb87c865ed 100644
> --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> @@ -57,8 +57,6 @@ patternProperties:
> specific binding.
> minItems: 1
> maxItems: 32
> - items:
> - maxItems: 1

Thanks for the fix,

Reviewed-by: Dhruva Gole <[email protected]>

--
Thanks and Regards,
Dhruva Gole

2024-03-05 14:50:47

by Rob Herring (Arm)

Subject: Re: [PATCH] dt-bindings: opp: drop maxItems from inner items

On Tue, 05 Mar 2024 00:43:06 +0100, David Heidelberg wrote:
> With recent changes within matrix dimensions calculation,
> dropping maxItems: 1 provides a warning-free run.
>
> Fixes warning such as:
> arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dtb: opp-table: opp-200000000:opp-hz:0: [200000000, 0, 0, 150000000, 0, 0, 0, 0, 300000000] is too long
>
> Fixes: 3cb16ad69bef ("dt-bindings: opp: accept array of frequencies")
> Suggested-by: Rob Herring <[email protected]>
> Signed-off-by: David Heidelberg <[email protected]>
> ---
> follow-up of https://lore.kernel.org/lkml/[email protected]/T/
>
> Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 --
> 1 file changed, 2 deletions(-)
>

Acked-by: Rob Herring <[email protected]>

2024-03-06 05:35:03

by Viresh Kumar

Subject: Re: [PATCH] dt-bindings: opp: drop maxItems from inner items

On 05-03-24, 00:43, David Heidelberg wrote:
> With recent changes within matrix dimensions calculation,
> dropping maxItems: 1 provides a warning-free run.
>
> Fixes warning such as:
> arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dtb: opp-table: opp-200000000:opp-hz:0: [200000000, 0, 0, 150000000, 0, 0, 0, 0, 300000000] is too long
>
> Fixes: 3cb16ad69bef ("dt-bindings: opp: accept array of frequencies")
> Suggested-by: Rob Herring <[email protected]>
> Signed-off-by: David Heidelberg <[email protected]>
> ---
> follow-up of https://lore.kernel.org/lkml/[email protected]/T/
>
> Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> index e2f8f7af3cf4..b1bb87c865ed 100644
> --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> @@ -57,8 +57,6 @@ patternProperties:
> specific binding.
> minItems: 1
> maxItems: 32
> - items:
> - maxItems: 1
>
> opp-microvolt:
> description: |

Applied. Thanks.

--
viresh