2024-03-06 14:44:03

by Doug Anderson

Subject: [PATCH] Revert "drm/udl: Add ARGB8888 as a format"

This reverts commit 95bf25bb9ed5dedb7fb39f76489f7d6843ab0475.

Apparently there was a previous discussion about emulation of formats
and it was decided XRGB8888 was the only format to support for legacy
userspace [1]. Remove ARGB8888. Userspace needs to be fixed to accept
XRGB8888.

[1] https://lore.kernel.org/r/[email protected]

Signed-off-by: Douglas Anderson <[email protected]>
---

drivers/gpu/drm/udl/udl_modeset.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c
index 0f8d3678770e..7702359c90c2 100644
--- a/drivers/gpu/drm/udl/udl_modeset.c
+++ b/drivers/gpu/drm/udl/udl_modeset.c
@@ -253,7 +253,6 @@ static int udl_handle_damage(struct drm_framebuffer *fb,
static const uint32_t udl_primary_plane_formats[] = {
DRM_FORMAT_RGB565,
DRM_FORMAT_XRGB8888,
- DRM_FORMAT_ARGB8888,
};

static const uint64_t udl_primary_plane_fmtmods[] = {
--
2.44.0.278.ge034bb2e1d-goog

2024-03-06 14:53:53

by Javier Martinez Canillas

Subject: Re: [PATCH] Revert "drm/udl: Add ARGB8888 as a format"

Douglas Anderson <[email protected]> writes:

Hello Doug,

> This reverts commit 95bf25bb9ed5dedb7fb39f76489f7d6843ab0475.
>
> Apparently there was a previous discussion about emulation of formats
> and it was decided XRGB8888 was the only format to support for legacy
> userspace [1]. Remove ARGB8888. Userspace needs to be fixed to accept
> XRGB8888.
>
> [1] https://lore.kernel.org/r/[email protected]
>
> Signed-off-by: Douglas Anderson <[email protected]>
> ---
>

Reviewed-by: Javier Martinez Canillas <[email protected]>

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

2024-03-06 15:22:29

by Doug Anderson

Subject: Re: [PATCH] Revert "drm/udl: Add ARGB8888 as a format"

Hi,

On Wed, Mar 6, 2024 at 6:38 AM Douglas Anderson <[email protected]> wrote:
>
> This reverts commit 95bf25bb9ed5dedb7fb39f76489f7d6843ab0475.
>
> Apparently there was a previous discussion about emulation of formats
> and it was decided XRGB8888 was the only format to support for legacy
> userspace [1]. Remove ARGB8888. Userspace needs to be fixed to accept
> XRGB8888.
>
> [1] https://lore.kernel.org/r/[email protected]
>
> Signed-off-by: Douglas Anderson <[email protected]>
> ---
>
> drivers/gpu/drm/udl/udl_modeset.c | 1 -
> 1 file changed, 1 deletion(-)

Pushed to drm-misc-fixes with Thomas and Javier's tags:

317f86dc1b8e Revert "drm/udl: Add ARGB8888 as a format"