2024-03-05 02:40:38

by Jiapeng Chong

Subject: [PATCH v2 2/2] xfs: Remove duplicate include

/fs/xfs/xfs_trace.c: xfs_bmap.h is included more than once.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8385
Signed-off-by: Jiapeng Chong <[email protected]>
---
Changes in v2:
-Remove the second #include.

fs/xfs/xfs_trace.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_trace.c b/fs/xfs/xfs_trace.c
index 1a963382e5e9..3f253884fe5b 100644
--- a/fs/xfs/xfs_trace.c
+++ b/fs/xfs/xfs_trace.c
@@ -38,7 +38,6 @@
#include "xfs_iomap.h"
#include "xfs_buf_mem.h"
#include "xfs_btree_mem.h"
-#include "xfs_bmap.h"

/*
* We include this last to have the helpers above available for the trace
--
2.20.1.7.g153144c

2024-03-06 15:39:27

by Darrick J. Wong

Subject: Re: [PATCH v2 2/2] xfs: Remove duplicate include

On Tue, Mar 05, 2024 at 10:40:09AM +0800, Jiapeng Chong wrote:
> ./fs/xfs/xfs_trace.c: xfs_bmap.h is included more than once.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8385
> Signed-off-by: Jiapeng Chong <[email protected]>

Reviewed-by: Darrick J. Wong <[email protected]>

--D

> ---
> Changes in v2:
> -Remove the second #include.
>
> fs/xfs/xfs_trace.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_trace.c b/fs/xfs/xfs_trace.c
> index 1a963382e5e9..3f253884fe5b 100644
> --- a/fs/xfs/xfs_trace.c
> +++ b/fs/xfs/xfs_trace.c
> @@ -38,7 +38,6 @@
> #include "xfs_iomap.h"
> #include "xfs_buf_mem.h"
> #include "xfs_btree_mem.h"
> -#include "xfs_bmap.h"
>
> /*
> * We include this last to have the helpers above available for the trace
> --
> 2.20.1.7.g153144c
>
>