2024-03-07 11:22:58

by Colin Ian King

[permalink] [raw]
Subject: [PATCH][next] net: chelsio: remove unused function calc_tx_descs

The inlined helper function calc_tx_descs is not used and is redundant.
Remove it.

Cleans up clang scan build warning:
drivers/net/ethernet/chelsio/cxgb4/sge.c:814:28: warning: unused
function 'calc_tx_descs' [-Wunused-function]

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/chelsio/cxgb4/sge.c | 14 --------------
1 file changed, 14 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c
index b5ff2e1a9975..49d5808b7d11 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/sge.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/sge.c
@@ -803,20 +803,6 @@ static inline unsigned int calc_tx_flits(const struct sk_buff *skb,
return flits;
}

-/**
- * calc_tx_descs - calculate the number of Tx descriptors for a packet
- * @skb: the packet
- * @chip_ver: chip version
- *
- * Returns the number of Tx descriptors needed for the given Ethernet
- * packet, including the needed WR and CPL headers.
- */
-static inline unsigned int calc_tx_descs(const struct sk_buff *skb,
- unsigned int chip_ver)
-{
- return flits_to_desc(calc_tx_flits(skb, chip_ver));
-}
-
/**
* cxgb4_write_sgl - populate a scatter/gather list for a packet
* @skb: the packet
--
2.39.2



2024-03-08 10:31:07

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH][next] net: chelsio: remove unused function calc_tx_descs

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <[email protected]>:

On Thu, 7 Mar 2024 11:22:37 +0000 you wrote:
> The inlined helper function calc_tx_descs is not used and is redundant.
> Remove it.
>
> Cleans up clang scan build warning:
> drivers/net/ethernet/chelsio/cxgb4/sge.c:814:28: warning: unused
> function 'calc_tx_descs' [-Wunused-function]
>
> [...]

Here is the summary with links:
- [next] net: chelsio: remove unused function calc_tx_descs
https://git.kernel.org/netdev/net-next/c/9b78bbef5138

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html