2024-03-07 15:22:13

by Muhammad Usama Anjum

Subject: [PATCH] mmc: dw_mmc: remove unneeded assignment

The err is being set to 0 and replaced every time after this
assignment. Remove this assignment as it is extraneous.

Fixes: e382ab741252 ("mmc: dw_mmc: add support for hi3798cv200 specific extensions of dw-mshc")
Signed-off-by: Muhammad Usama Anjum <[email protected]>
---
drivers/mmc/host/dw_mmc-hi3798cv200.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/mmc/host/dw_mmc-hi3798cv200.c b/drivers/mmc/host/dw_mmc-hi3798cv200.c
index 61923a5183693..6099756e59b3c 100644
--- a/drivers/mmc/host/dw_mmc-hi3798cv200.c
+++ b/drivers/mmc/host/dw_mmc-hi3798cv200.c
@@ -87,7 +87,6 @@ static int dw_mci_hi3798cv200_execute_tuning(struct dw_mci_slot *slot,
goto tuning_out;

prev_err = err;
- err = 0;
}

tuning_out:
--
2.39.2

2024-03-25 13:12:40

by Muhammad Usama Anjum

Subject: Re: [PATCH] mmc: dw_mmc: remove unneeded assignment

Soft reminder

On 3/7/24 7:50 PM, Muhammad Usama Anjum wrote:
> The err is being set to 0 and replaced every time after this
> assignment. Remove this assignment as it is extraneous.
>
> Fixes: e382ab741252 ("mmc: dw_mmc: add support for hi3798cv200 specific extensions of dw-mshc")
> Signed-off-by: Muhammad Usama Anjum <[email protected]>
> ---
> drivers/mmc/host/dw_mmc-hi3798cv200.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-hi3798cv200.c b/drivers/mmc/host/dw_mmc-hi3798cv200.c
> index 61923a5183693..6099756e59b3c 100644
> --- a/drivers/mmc/host/dw_mmc-hi3798cv200.c
> +++ b/drivers/mmc/host/dw_mmc-hi3798cv200.c
> @@ -87,7 +87,6 @@ static int dw_mci_hi3798cv200_execute_tuning(struct dw_mci_slot *slot,
> goto tuning_out;
>
> prev_err = err;
> - err = 0;
> }
>
> tuning_out:

--
BR,
Muhammad Usama Anjum

2024-03-25 16:03:29

by Ulf Hansson

Subject: Re: [PATCH] mmc: dw_mmc: remove unneeded assignment

On Thu, 7 Mar 2024 at 15:49, Muhammad Usama Anjum
<[email protected]> wrote:
>
> The err is being set to 0 and replaced every time after this
> assignment. Remove this assignment as it is extraneous.
>
> Fixes: e382ab741252 ("mmc: dw_mmc: add support for hi3798cv200 specific extensions of dw-mshc")

I don't think we need a fixes tag here, so I have dropped it.

> Signed-off-by: Muhammad Usama Anjum <[email protected]>

Applied for next and by amending the commit message prefix to "mmc:
dw_mmc-hi3798cv200", thanks!

Kind regards
Uffe


> ---
> drivers/mmc/host/dw_mmc-hi3798cv200.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-hi3798cv200.c b/drivers/mmc/host/dw_mmc-hi3798cv200.c
> index 61923a5183693..6099756e59b3c 100644
> --- a/drivers/mmc/host/dw_mmc-hi3798cv200.c
> +++ b/drivers/mmc/host/dw_mmc-hi3798cv200.c
> @@ -87,7 +87,6 @@ static int dw_mci_hi3798cv200_execute_tuning(struct dw_mci_slot *slot,
> goto tuning_out;
>
> prev_err = err;
> - err = 0;
> }
>
> tuning_out:
> --
> 2.39.2
>