2024-03-07 19:20:30

by Frank Li

[permalink] [raw]
Subject: [PATCH v5 3/4] ASoC: dt-bindings: fsl-sai: allow only one dma-names

Some sai only connect one direction dma (rx/tx) in SOC. For example:
imx8qxp sai5 only connect tx dma channel. So allow only one "rx" or "tx"
for dma-names.

Remove description under dmas because no user use index to get dma channel.
All user use 'dma-names' to get correct dma channel. dma-names already in
'required' list.

Acked-by: Conor Dooley <[email protected]>
Signed-off-by: Frank Li <[email protected]>
---
Documentation/devicetree/bindings/sound/fsl,sai.yaml | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/fsl,sai.yaml b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
index 2456d958adeef..93e7737a49a7b 100644
--- a/Documentation/devicetree/bindings/sound/fsl,sai.yaml
+++ b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
@@ -81,15 +81,13 @@ properties:

dmas:
minItems: 1
- items:
- - description: DMA controller phandle and request line for RX
- - description: DMA controller phandle and request line for TX
+ maxItems: 2

dma-names:
minItems: 1
+ maxItems: 2
items:
- - const: rx
- - const: tx
+ enum: [ rx, tx ]

interrupts:
items:

--
2.34.1



2024-03-08 16:33:38

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH v5 3/4] ASoC: dt-bindings: fsl-sai: allow only one dma-names

On Thu, Mar 07, 2024 at 02:19:10PM -0500, Frank Li wrote:
> Some sai only connect one direction dma (rx/tx) in SOC. For example:
> imx8qxp sai5 only connect tx dma channel. So allow only one "rx" or "tx"
> for dma-names.
>
> Remove description under dmas because no user use index to get dma channel.
> All user use 'dma-names' to get correct dma channel. dma-names already in
> 'required' list.
>
> Acked-by: Conor Dooley <[email protected]>

Could you please drop the ack when you change a patch significantly
between versions?

> Signed-off-by: Frank Li <[email protected]>
> ---
> Documentation/devicetree/bindings/sound/fsl,sai.yaml | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,sai.yaml b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> index 2456d958adeef..93e7737a49a7b 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> @@ -81,15 +81,13 @@ properties:
>
> dmas:
> minItems: 1
> - items:
> - - description: DMA controller phandle and request line for RX
> - - description: DMA controller phandle and request line for TX
> + maxItems: 2
>
> dma-names:
> minItems: 1
> + maxItems: 2
> items:
> - - const: rx
> - - const: tx
> + enum: [ rx, tx ]
>
> interrupts:
> items:
>
> --
> 2.34.1
>


Attachments:
(No filename) (1.46 kB)
signature.asc (235.00 B)
Download all attachments