2024-03-08 07:53:37

by Hayes Wang

Subject: [PATCH net] r8152: fix unknown device for choose_configuration

For the unknown device, rtl8152_cfgselector_choose_configuration()
should return a negative value. Then, usb_choose_configuration() would
set a configuration for CDC ECM or NCM mode. Otherwise, there is no
usb interface driver for the device.

Fixes: aa4f2b3e418e ("r8152: Choose our USB config with choose_configuration() rather than probe()")
Signed-off-by: Hayes Wang <[email protected]>
---
drivers/net/usb/r8152.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 0d0672d2a654..51fe00c2b896 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -10078,7 +10078,7 @@ static int rtl8152_cfgselector_choose_configuration(struct usb_device *udev)
* driver supports it.
*/
if (__rtl_get_hw_ver(udev) == RTL_VER_UNKNOWN)
- return 0;
+ return -ENODEV;

/* The vendor mode is not always config #1, so to find it out. */
c = udev->config;
--
2.43.0

2024-03-11 23:00:55

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net] r8152: fix unknown device for choose_configuration

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

On Fri, 8 Mar 2024 15:52:06 +0800 you wrote:
> For the unknown device, rtl8152_cfgselector_choose_configuration()
> should return a negative value. Then, usb_choose_configuration() would
> set a configuration for CDC ECM or NCM mode. Otherwise, there is no
> usb interface driver for the device.
>
> Fixes: aa4f2b3e418e ("r8152: Choose our USB config with choose_configuration() rather than probe()")
> Signed-off-by: Hayes Wang <[email protected]>
>
> [...]

Here is the summary with links:
- [net] r8152: fix unknown device for choose_configuration
https://git.kernel.org/netdev/net/c/46590b545df6

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html