2024-03-08 13:57:22

by Colin Ian King

Subject: [PATCH][next] dmaengine: pch_dma: remove unused function chan2parent

The helper function chan2parent is not used and has never been
used since the first commit to the code back in 2010. The function
is redundant and can be removed.

Cleans up clang scan build warning:
drivers/dma/pch_dma.c:158:30: warning: unused function 'chan2parent' [-Wunused-function]

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/dma/pch_dma.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
index c359decc07a3..6b2793b07694 100644
--- a/drivers/dma/pch_dma.c
+++ b/drivers/dma/pch_dma.c
@@ -155,11 +155,6 @@ static inline struct device *chan2dev(struct dma_chan *chan)
return &chan->dev->device;
}

-static inline struct device *chan2parent(struct dma_chan *chan)
-{
- return chan->dev->device.parent;
-}
-
static inline
struct pch_dma_desc *pdc_first_active(struct pch_dma_chan *pd_chan)
{
--
2.39.2

2024-04-07 16:41:24

by Vinod Koul

Subject: Re: [PATCH][next] dmaengine: pch_dma: remove unused function chan2parent

On Fri, 08 Mar 2024 13:47:50 +0000, Colin Ian King wrote:
> The helper function chan2parent is not used and has never been
> used since the first commit to the code back in 2010. The function
> is redundant and can be removed.
>
> Cleans up clang scan build warning:
> drivers/dma/pch_dma.c:158:30: warning: unused function 'chan2parent' [-Wunused-function]
>
> [...]

Applied, thanks!

[1/1] dmaengine: pch_dma: remove unused function chan2parent
commit: 4665be0e952f68306cc6fba2cce68b940a7ec78c

Best regards,
--
~Vinod