2024-03-10 21:13:22

by Chris Packham

Subject: [PATCH] auxdisplay: seg-led-gpio: Import linedisp namespace

The seg-led-gpio driver uses symbols from the linedisp namespace. Ensure
these are imported.

Fixes: 899383f9ecf5 ("auxdisplay: Add 7-segment LED display driver")
Signed-off-by: Chris Packham <[email protected]>
---
drivers/auxdisplay/seg-led-gpio.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/auxdisplay/seg-led-gpio.c b/drivers/auxdisplay/seg-led-gpio.c
index 5dc2a006cac5..35a8dbb1e9d2 100644
--- a/drivers/auxdisplay/seg-led-gpio.c
+++ b/drivers/auxdisplay/seg-led-gpio.c
@@ -110,3 +110,4 @@ module_platform_driver(seg_led_driver);
MODULE_AUTHOR("Chris Packham <[email protected]>");
MODULE_DESCRIPTION("7 segment LED driver");
MODULE_LICENSE("GPL");
+MODULE_IMPORT_NS(LINEDISP);
--
2.43.2

2024-03-11 09:47:48

by Geert Uytterhoeven

Subject: Re: [PATCH] auxdisplay: seg-led-gpio: Import linedisp namespace

On Sun, Mar 10, 2024 at 10:13 PM Chris Packham
<[email protected]> wrote:
> The seg-led-gpio driver uses symbols from the linedisp namespace. Ensure
> these are imported.
>
> Fixes: 899383f9ecf5 ("auxdisplay: Add 7-segment LED display driver")

Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/r/[email protected]/

> Signed-off-by: Chris Packham <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2024-03-11 09:57:38

by Andy Shevchenko

Subject: Re: [PATCH] auxdisplay: seg-led-gpio: Import linedisp namespace

On Mon, Mar 11, 2024 at 10:46:17AM +0100, Geert Uytterhoeven wrote:
> On Sun, Mar 10, 2024 at 10:13 PM Chris Packham
> <[email protected]> wrote:
> > The seg-led-gpio driver uses symbols from the linedisp namespace. Ensure
> > these are imported.
> >
> > Fixes: 899383f9ecf5 ("auxdisplay: Add 7-segment LED display driver")
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/r/[email protected]/
>
> > Signed-off-by: Chris Packham <[email protected]>
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>

Pushed to my review and testing queue, thanks!

--
With Best Regards,
Andy Shevchenko