2024-03-11 19:17:31

by Gabor Juhos

Subject: [PATCH 1/2] clk: qcom: clk-alpha-pll: remove invalid Stromer register offset

The offset of the CONFIG_CTL_U register defined for the Stromer
PLL is wrong. It is not aligned on a 4 bytes boundary which might
causes errors in regmap operations.

Maybe the intention behind of using the 0xff value was to indicate
that the register is not implemented in the PLL, but this is not
verified anywhere in the code. Moreover, this value is not used
even in other register offset arrays despite that those PLLs also
have unimplemented registers.

Additionally, on the Stromer PLLs the current code only touches
the CONFIG_CTL_U register if the result of pll_has_64bit_config()
is true which condition is not affected by the change.

Due to the reasons above, simply remove the CONFIG_CTL_U entry
from the Stromer specific array.

Fixes: e47a4f55f240 ("clk: qcom: clk-alpha-pll: Add support for Stromer PLLs")
Signed-off-by: Gabor Juhos <[email protected]>
---
drivers/clk/qcom/clk-alpha-pll.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c
index 05898d2a8b22c..58ae732959803 100644
--- a/drivers/clk/qcom/clk-alpha-pll.c
+++ b/drivers/clk/qcom/clk-alpha-pll.c
@@ -212,7 +212,6 @@ const u8 clk_alpha_pll_regs[][PLL_OFF_MAX_REGS] = {
[PLL_OFF_USER_CTL] = 0x18,
[PLL_OFF_USER_CTL_U] = 0x1c,
[PLL_OFF_CONFIG_CTL] = 0x20,
- [PLL_OFF_CONFIG_CTL_U] = 0xff,
[PLL_OFF_TEST_CTL] = 0x30,
[PLL_OFF_TEST_CTL_U] = 0x34,
[PLL_OFF_STATUS] = 0x28,

--
2.44.0

2024-03-12 00:02:02

by Konrad Dybcio

Subject: Re: [PATCH 1/2] clk: qcom: clk-alpha-pll: remove invalid Stromer register offset

On 3/11/24 19:45, Gabor Juhos wrote:
> The offset of the CONFIG_CTL_U register defined for the Stromer
> PLL is wrong. It is not aligned on a 4 bytes boundary which might
> causes errors in regmap operations.
>
> Maybe the intention behind of using the 0xff value was to indicate
> that the register is not implemented in the PLL, but this is not
> verified anywhere in the code. Moreover, this value is not used
> even in other register offset arrays despite that those PLLs also
> have unimplemented registers.
>
> Additionally, on the Stromer PLLs the current code only touches
> the CONFIG_CTL_U register if the result of pll_has_64bit_config()
> is true which condition is not affected by the change.
>
> Due to the reasons above, simply remove the CONFIG_CTL_U entry
> from the Stromer specific array.
>
> Fixes: e47a4f55f240 ("clk: qcom: clk-alpha-pll: Add support for Stromer PLLs")
> Signed-off-by: Gabor Juhos <[email protected]>
> ---

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad>