Fastchannels are initialized with a bad index in:
commit 2441caa84aac ("firmware: arm_scmi: Populate fast channel rate_limit")
Fix this and provide a correct index.
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Closes: https://lore.kernel.org/r/[email protected]/
Signed-off-by: Pierre Gondois <[email protected]>
---
drivers/firmware/arm_scmi/powercap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/arm_scmi/powercap.c b/drivers/firmware/arm_scmi/powercap.c
index ea9201e7044c..1fa79bba492e 100644
--- a/drivers/firmware/arm_scmi/powercap.c
+++ b/drivers/firmware/arm_scmi/powercap.c
@@ -736,7 +736,7 @@ static void scmi_powercap_domain_init_fc(const struct scmi_protocol_handle *ph,
ph->hops->fastchannel_init(ph, POWERCAP_DESCRIBE_FASTCHANNEL,
POWERCAP_PAI_GET, 4, domain,
&fc[POWERCAP_FC_PAI].get_addr, NULL,
- &fc[POWERCAP_PAI_GET].rate_limit);
+ &fc[POWERCAP_FC_PAI].rate_limit);
*p_fc = fc;
}
--
2.25.1
On Mon, Mar 11, 2024 at 10:04:12AM +0100, Pierre Gondois wrote:
> Fastchannels are initialized with a bad index in:
> commit 2441caa84aac ("firmware: arm_scmi: Populate fast channel rate_limit")
> Fix this and provide a correct index.
>
> Reported-by: kernel test robot <[email protected]>
> Reported-by: Dan Carpenter <[email protected]>
Nice catch!
> Closes: https://lore.kernel.org/r/[email protected]/
> Signed-off-by: Pierre Gondois <[email protected]>
Reviewed-by: Sudeep Holla <[email protected]>
--
Regards,
Sudeep
On Mon, 11 Mar 2024 10:04:12 +0100, Pierre Gondois wrote:
> Fastchannels are initialized with a bad index in:
> commit 2441caa84aac ("firmware: arm_scmi: Populate fast channel rate_limit")
> Fix this and provide a correct index.
>
>
Applied to sudeep.holla/linux (for-next/scmi/fixes), thanks!
[1/1] firmware: arm_scmi: Fix wrong fastchannel initialization
https://git.kernel.org/sudeep.holla/c/17f243adf165
--
Regards,
Sudeep