2024-03-13 18:37:11

by Jérémie Dautheribes

[permalink] [raw]
Subject: [PATCH v3 0/3] panel-simple: add support for Crystal Clear CMT430B19N00

Hello everyone,

This patch series add support for the Crystal Clear Technology
CMT430B19N00 4.3" 480x272 TFT-LCD panel.
It also adds Crystal Clear Technology to vendor-prefixes.yaml.

Please note that unfortunately there is no public datasheet available
for this panel.

Changes in v3:
- PATCH 3/3: use display_timing structure instead of display_mode
structure as suggested by Maxime Ripard.
- Link to v2: https://lore.kernel.org/all/[email protected]/

Changes in v2:
- add link to the Crystal Clear Technology website in commit message, as
suggested by Conor Dooley and Neil Armstrong.
- Link to v1: https://lore.kernel.org/all/[email protected]/

Regards,

Jérémie

Jérémie Dautheribes (3):
dt-bindings: Add Crystal Clear Technology vendor prefix
dt-bindings: display: simple: add support for Crystal Clear
CMT430B19N00
drm/panel: simple: add CMT430B19N00 LCD panel support

.../bindings/display/panel/panel-simple.yaml | 2 ++
.../devicetree/bindings/vendor-prefixes.yaml | 2 ++
drivers/gpu/drm/panel/panel-simple.c | 29 +++++++++++++++++++
3 files changed, 33 insertions(+)

--
2.34.1


2024-03-13 18:40:17

by Jérémie Dautheribes

[permalink] [raw]
Subject: [PATCH v3 2/3] dt-bindings: display: simple: add support for Crystal Clear CMT430B19N00

Add Crystal Clear Technology CMT430B19N00 4.3" 480x272 TFT-LCD panel
compatible string.

Acked-by: Krzysztof Kozlowski <[email protected]>
Acked-by: Conor Dooley <[email protected]>
Signed-off-by: Jérémie Dautheribes <[email protected]>
---
.../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index a95445f40870..c575f7c4b745 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -91,6 +91,8 @@ properties:
- boe,nv133fhm-n62
# BOE NV140FHM-N49 14.0" FHD a-Si FT panel
- boe,nv140fhmn49
+ # Crystal Clear Technology CMT430B19N00 4.3" 480x272 TFT-LCD panel
+ - cct,cmt430b19n00
# CDTech(H.K.) Electronics Limited 4.3" 480x272 color TFT-LCD panel
- cdtech,s043wq26h-ct7
# CDTech(H.K.) Electronics Limited 7" WSVGA (1024x600) TFT LCD Panel
--
2.34.1


2024-03-13 18:41:14

by Jérémie Dautheribes

[permalink] [raw]
Subject: [PATCH v3 3/3] drm/panel: simple: add CMT430B19N00 LCD panel support

Add support for Crystal Clear Technology CMT430B19N00 4.3" 480x272
TFT-LCD panel.

Suggested-by: Maxime Ripard <[email protected]>
Signed-off-by: Jérémie Dautheribes <[email protected]>
---
drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 20e3df1c59d4..d13c42d0f57b 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1457,6 +1457,32 @@ static const struct panel_desc boe_hv070wsa = {
.connector_type = DRM_MODE_CONNECTOR_LVDS,
};

+static const struct display_timing cct_cmt430b19n00_timing = {
+ .pixelclock = { 8000000, 9000000, 12000000 },
+ .hactive = { 480, 480, 480 },
+ .hfront_porch = { 2, 8, 75 },
+ .hback_porch = { 3, 43, 43 },
+ .hsync_len = { 2, 4, 75 },
+ .vactive = { 272, 272, 272 },
+ .vfront_porch = { 2, 8, 37 },
+ .vback_porch = { 2, 12, 12 },
+ .vsync_len = { 2, 4, 37 },
+ .flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW
+};
+
+static const struct panel_desc cct_cmt430b19n00 = {
+ .timings = &cct_cmt430b19n00_timing,
+ .num_timings = 1,
+ .bpc = 8,
+ .size = {
+ .width = 95,
+ .height = 53,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE,
+ .connector_type = DRM_MODE_CONNECTOR_DPI,
+};
+
static const struct drm_display_mode cdtech_s043wq26h_ct7_mode = {
.clock = 9000,
.hdisplay = 480,
@@ -4402,6 +4428,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "boe,hv070wsa-100",
.data = &boe_hv070wsa
+ }, {
+ .compatible = "cct,cmt430b19n00",
+ .data = &cct_cmt430b19n00,
}, {
.compatible = "cdtech,s043wq26h-ct7",
.data = &cdtech_s043wq26h_ct7,
--
2.34.1


2024-03-13 18:43:37

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH v3 3/3] drm/panel: simple: add CMT430B19N00 LCD panel support

On 13/03/2024 18:20, Jérémie Dautheribes wrote:
> Add support for Crystal Clear Technology CMT430B19N00 4.3" 480x272
> TFT-LCD panel.
>
> Suggested-by: Maxime Ripard <[email protected]>
> Signed-off-by: Jérémie Dautheribes <[email protected]>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 20e3df1c59d4..d13c42d0f57b 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1457,6 +1457,32 @@ static const struct panel_desc boe_hv070wsa = {
> .connector_type = DRM_MODE_CONNECTOR_LVDS,
> };
>
> +static const struct display_timing cct_cmt430b19n00_timing = {
> + .pixelclock = { 8000000, 9000000, 12000000 },
> + .hactive = { 480, 480, 480 },
> + .hfront_porch = { 2, 8, 75 },
> + .hback_porch = { 3, 43, 43 },
> + .hsync_len = { 2, 4, 75 },
> + .vactive = { 272, 272, 272 },
> + .vfront_porch = { 2, 8, 37 },
> + .vback_porch = { 2, 12, 12 },
> + .vsync_len = { 2, 4, 37 },
> + .flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW
> +};
> +
> +static const struct panel_desc cct_cmt430b19n00 = {
> + .timings = &cct_cmt430b19n00_timing,
> + .num_timings = 1,
> + .bpc = 8,
> + .size = {
> + .width = 95,
> + .height = 53,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE,
> + .connector_type = DRM_MODE_CONNECTOR_DPI,
> +};
> +
> static const struct drm_display_mode cdtech_s043wq26h_ct7_mode = {
> .clock = 9000,
> .hdisplay = 480,
> @@ -4402,6 +4428,9 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "boe,hv070wsa-100",
> .data = &boe_hv070wsa
> + }, {
> + .compatible = "cct,cmt430b19n00",
> + .data = &cct_cmt430b19n00,
> }, {
> .compatible = "cdtech,s043wq26h-ct7",
> .data = &cdtech_s043wq26h_ct7,

Reviewed-by: Neil Armstrong <[email protected]>

2024-03-13 19:10:40

by Jérémie Dautheribes

[permalink] [raw]
Subject: [PATCH v3 1/3] dt-bindings: Add Crystal Clear Technology vendor prefix

Update Documentation/devicetree/bindings/vendor-prefixes.yaml to
include "cct" as a vendor prefix for "Crystal Clear Technology". CCT is
the vendor of the CMT430B19N00 TFT-LCD panel.

Link: http://www.cct.com.my/
Acked-by: Krzysztof Kozlowski <[email protected]>
Acked-by: Conor Dooley <[email protected]>
Signed-off-by: Jérémie Dautheribes <[email protected]>
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index fef2e12b504e..96e47742e250 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -248,6 +248,8 @@ patternProperties:
description: Catalyst Semiconductor, Inc.
"^cavium,.*":
description: Cavium, Inc.
+ "^cct,.*":
+ description: Crystal Clear Technology Sdn. Bhd.
"^cdns,.*":
description: Cadence Design Systems Inc.
"^cdtech,.*":
--
2.34.1


2024-03-13 19:17:14

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH v3 0/3] panel-simple: add support for Crystal Clear CMT430B19N00

From: Neil Armstrong <[email protected]>

Hi,

On Wed, 13 Mar 2024 18:20:13 +0100, Jérémie Dautheribes wrote:
> This patch series add support for the Crystal Clear Technology
> CMT430B19N00 4.3" 480x272 TFT-LCD panel.
> It also adds Crystal Clear Technology to vendor-prefixes.yaml.
>
> Please note that unfortunately there is no public datasheet available
> for this panel.
>
> [...]

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

[1/3] dt-bindings: Add Crystal Clear Technology vendor prefix
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/fe67bfbd23b0ccfaaa5de9f9176c6283c628cea1
[2/3] dt-bindings: display: simple: add support for Crystal Clear CMT430B19N00
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/2fbb050335f8195b86ebcdf498a6c171bba10f8d
[3/3] drm/panel: simple: add CMT430B19N00 LCD panel support
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/751b58418250a56329d35de29329f547c43e7c7f

--
Neil