2024-03-14 12:34:07

by Herve Codina

Subject: [PATCH] net: wan: fsl_qmc_hdlc: Fix module compilation

The fsl_qmc_driver does not compile as module:
error: ‘qmc_hdlc_driver’ undeclared here (not in a function);
405 | MODULE_DEVICE_TABLE(of, qmc_hdlc_driver);
| ^~~~~~~~~~~~~~~

Fix the typo.

Fixes: b40f00ecd463 ("net: wan: Add support for QMC HDLC")
Reported-by: Michael Ellerman <[email protected]>
Closes: https://lore.kernel.org/linux-kernel/[email protected]/
Signed-off-by: Herve Codina <[email protected]>
---
drivers/net/wan/fsl_qmc_hdlc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wan/fsl_qmc_hdlc.c b/drivers/net/wan/fsl_qmc_hdlc.c
index 960371df470a..f69b1f579a0c 100644
--- a/drivers/net/wan/fsl_qmc_hdlc.c
+++ b/drivers/net/wan/fsl_qmc_hdlc.c
@@ -780,7 +780,7 @@ static const struct of_device_id qmc_hdlc_id_table[] = {
{ .compatible = "fsl,qmc-hdlc" },
{} /* sentinel */
};
-MODULE_DEVICE_TABLE(of, qmc_hdlc_driver);
+MODULE_DEVICE_TABLE(of, qmc_hdlc_id_table);

static struct platform_driver qmc_hdlc_driver = {
.driver = {
--
2.44.0

2024-03-18 09:31:28

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net: wan: fsl_qmc_hdlc: Fix module compilation

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:

On Thu, 14 Mar 2024 13:33:46 +0100 you wrote:
> The fsl_qmc_driver does not compile as module:
> error: ‘qmc_hdlc_driver’ undeclared here (not in a function);
> 405 | MODULE_DEVICE_TABLE(of, qmc_hdlc_driver);
> | ^~~~~~~~~~~~~~~
>
> Fix the typo.
>
> [...]

Here is the summary with links:
- net: wan: fsl_qmc_hdlc: Fix module compilation
https://git.kernel.org/netdev/net/c/badc9e33c795

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html